Skip to content

4.0] Active indicator on wrong side in RTL#27405

Merged
HLeithner merged 3 commits intojoomla:4.0-devfrom
brianteeman:rtl
Jan 6, 2020
Merged

4.0] Active indicator on wrong side in RTL#27405
HLeithner merged 3 commits intojoomla:4.0-devfrom
brianteeman:rtl

Conversation

@brianteeman
Copy link
Contributor

Pull Request for Issue #24704

Summary of Changes

See #24704 for details

Testing Instructions

npm i

@Quy
Copy link
Contributor

Quy commented Jan 5, 2020

I have tested this item ✅ successfully on 8a6f4b2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27405.

@infograf768
Copy link
Member

Please post screenshot. What is the active indicator ?

@Quy
Copy link
Contributor

Quy commented Jan 5, 2020

See #27404

@jwaisner
Copy link
Member

jwaisner commented Jan 5, 2020

I have tested this item ✅ successfully on 8a6f4b2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27405.

@Quy Quy removed the PR-4.0-dev label Jan 5, 2020
@Quy
Copy link
Contributor

Quy commented Jan 5, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27405.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 5, 2020
@infograf768
Copy link
Member

OK to go after cs is corrected.

@infograf768
Copy link
Member

@wilsonge @HLeithner
Good to go. (Drone failing unrelated)

@HLeithner HLeithner merged commit 54b89d9 into joomla:4.0-dev Jan 6, 2020
@HLeithner
Copy link
Member

Thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 6, 2020
@HLeithner HLeithner added this to the Joomla 4.0 milestone Jan 6, 2020
@brianteeman brianteeman deleted the rtl branch January 6, 2020 16:08
brianteeman added a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants