[4.0] Change plugin statistics popup to be alertdialog#27189
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Dec 2, 2019
Merged
[4.0] Change plugin statistics popup to be alertdialog#27189wilsonge merged 2 commits intojoomla:4.0-devfrom
wilsonge merged 2 commits intojoomla:4.0-devfrom
Conversation
Contributor
|
I have tested this item ✅ successfully on 4f55581 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27189. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 4f55581 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27189. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27189. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #22507 .
Summary of Changes
The plugin statistics popup should not have a
role=alertas this role does not allow for a response by the user, instead it should have arole=alertdialog.Testing Instructions
Enable
System - Joomla! Statisticsplugin.View markup of the popup.
See
role="alert".Apply PR.
See
role="alertdialog".