[4.0] Fixing iframes missing assets#27187
Merged
wilsonge merged 9 commits intojoomla:4.0-devfrom Dec 3, 2019
dgrammatiko:patch-3
Merged
[4.0] Fixing iframes missing assets#27187wilsonge merged 9 commits intojoomla:4.0-devfrom dgrammatiko:patch-3
wilsonge merged 9 commits intojoomla:4.0-devfrom
dgrammatiko:patch-3
Conversation
dgrammatiko
changed the title
Fedik
reviewed
Dec 1, 2019
| // Load specific language related CSS | ||
| HTMLHelper::_('stylesheet', 'administrator/language/' . $lang->getTag() . '/' . $lang->getTag() . '.css', array('version' => 'auto')); | ||
| // TODO: remove the following line whenever the assets are fixed to respect the ovverides | ||
| HTMLHelper::_('stylesheet', 'vendor/choicesjs/choices.css', array('version' => 'auto', 'relative' => true)); |
Member
There was a problem hiding this comment.
And this will stay here forever, no one will know what choices.css doing here.
If cannot be fixed a reason of the bug, leave the bug live.
I will check the overriding problem with #25775 or after that will be merged, it not that critical.
Contributor
Author
There was a problem hiding this comment.
And this will stay here forever
I'm not sure what else can be done atm. Also this isn't the first @todo in the project
infograf768
reviewed
Dec 2, 2019
Member
|
I have tested this item ✅ successfully on 25cadbb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27187. |
brianteeman
reviewed
Dec 2, 2019
Co-Authored-By: Brian Teeman <brian@teeman.net>
Quy
reviewed
Dec 3, 2019
Quy
reviewed
Dec 3, 2019
Quy
reviewed
Dec 3, 2019
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Contributor
|
I have tested this item ✅ successfully on a9c46be This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27187. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27187. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #26077 (comment)
Summary of Changes
Include all the needed assets for the iframes
Testing Instructions
git pullnpm ICheck the multilingual associations side by side view
Expected result
No styles missing
Actual result
Styles missing
Documentation Changes Required