[4.0] [plg_sampledata_multilang] Add missing checks#27183
Merged
wilsonge merged 4 commits intojoomla:4.0-devfrom Dec 3, 2019
SharkyKZ:j4/plg_sampledata_multilang
Merged
[4.0] [plg_sampledata_multilang] Add missing checks#27183wilsonge merged 4 commits intojoomla:4.0-devfrom SharkyKZ:j4/plg_sampledata_multilang
wilsonge merged 4 commits intojoomla:4.0-devfrom
SharkyKZ:j4/plg_sampledata_multilang
Conversation
Contributor
|
I have tested this item ✅ successfully on e3ebc69 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27183. |
Member
|
@SharkyKZ I suggest to also correct that one in this PR. |
Contributor
Author
|
Not really necessary in the last step. |
Member
|
I have tested this item ✅ successfully on a03ac6e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27183. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27183. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Adds context check in last step. Fixes weird alert when installing Testing Sample Data.
Testing Instructions
Expected result
Actual result
Documentation Changes Required
No.