Skip to content

Create JHtml::_('behavior.core') to decouble core.js from mootools framework #2696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Bakual wants to merge 3 commits into from
Closed

Create JHtml::_('behavior.core') to decouble core.js from mootools framework #2696

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a3fd57
Adding new JHtml function behavior.core to load core.js
Dec 18, 2013
214d159
Creating it as a proxy for now
Dec 18, 2013
174a241
Adding back in core.js
Dec 18, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions libraries/cms/html/behavior.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,12 +61,49 @@ public static function framework($extras = false, $debug = null)
}

JHtml::_('script', 'system/mootools-' . $type . '.js', false, true, false, false, $debug);

// Remove as soon as core.js is rewritten to jQuery (Pull https://github.com/joomla/joomla-cms/pull/2687)
JHtml::_('script', 'system/core.js', false, true);

/* Uncomment as soon as core.js is rewritten to jQuery
// Keep loading core.js for BC reasons
static::core();
*/

static::$loaded[__METHOD__][$type] = true;

return;
}

/**
* Method to load core.js into the document head.
*
* Core.js defines the 'Joomla' namespace and contains functions which are used across extensions
*
* @return void
*
* @since 3.2.2
*/
public static function core()
{
// Only a proxy for now. Remove when core.js is rewritten to jQuery (Pull https://github.com/joomla/joomla-cms/pull/2687)
static::framework();

/* Uncomment as soon as core.js is rewritten to jQuery
// Only load once
if (isset(static::$loaded[__METHOD__]))
{
return;
}

JHtml::_('jquery.framework');
JHtml::_('script', 'system/core.js', false, true);
static::$loaded[__METHOD__] = true;
*/

return;
}

/**
* Add unobtrusive JavaScript support for image captions.
*
Expand Down