Skip to content

[4.0] installer missing language string#26732

Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom
brianteeman:pbf3
Oct 19, 2019
Merged

[4.0] installer missing language string#26732
wilsonge merged 1 commit intojoomla:4.0-devfrom
brianteeman:pbf3

Conversation

@brianteeman
Copy link
Contributor

as reported by @pe7er #26620 with the code from @infograf768

Sorry no idea how to replicate the bug

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Oct 19, 2019
@wilsonge
Copy link
Contributor

To replicate just install Joomla with no internet connection. You get the message displayed when you load the Joomla is installed successfully page (as that's the point where we load all the language packs update sites)

@wilsonge wilsonge removed Language Change This is for Translators PR-4.0-dev labels Oct 19, 2019
@wilsonge
Copy link
Contributor

I have tested this item ✅ successfully on 38f4b69

After patch when installing Joomla with no internet connection message now shows as translated.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26732.

@SharkyKZ
Copy link
Contributor

I have tested this item ✅ successfully on 38f4b69


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26732.

@SharkyKZ
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26732.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 19, 2019
@wilsonge wilsonge merged commit ad463f4 into joomla:4.0-dev Oct 19, 2019
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Oct 19, 2019
@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the pbf3 branch October 19, 2019 23:25
@pe7er
Copy link
Contributor

pe7er commented Oct 20, 2019

Sorry no idea how to replicate the bug

You have to take the train from Nijmegen to Utrecht and near train station Ede-Wageningen, try to install Joomla 4 alpha on your laptop :-)

To replicate just install Joomla with no internet connection.

Yes, indeed. I got the message when I installed it while traveling on the train.
Apparently the internet connection was a bit wonky.

@brianteeman Thanks for fixing it.

@wilsonge wilsonge added this to the Joomla 4.0 milestone Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants