[4.0] No default for created time of privacy consents for new installs.#26725
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Oct 19, 2019
Merged
Conversation
Contributor
|
Thanks! |
Member
Author
|
Thanks too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
With PR #26561, the datetime database colums have been fixed for com_privacy, but the changes done with this PR here have been forgotten.
Testing Instructions
Code review: Check that the changes here fit to files
administrator/components/com_admin/sql/updates/mysql/4.0.0-2019-09-26.sqlandadministrator/components/com_admin/sql/updates/mysql/4.0.0-2019-09-26.sqlin the current 4.0-dev branch.Expected result
No default value for column
createdof table#__privacy_consentsafter new installation.Actual result
Column
createdof table#__privacy_consentshas a default value in filejoomla.sqlbut would not have after an update due to file4.0.0-2019-09-26.sql.Documentation Changes Required