[4.0] Heading is missing on "Template Preview" Popup#26720
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Oct 19, 2019
Merged
[4.0] Heading is missing on "Template Preview" Popup#26720wilsonge merged 1 commit intojoomla:4.0-devfrom
wilsonge merged 1 commit intojoomla:4.0-devfrom
Conversation
37bf5b5 to
074c694
Compare
Contributor
|
I have tested this item ✅ successfully on 074c694 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26720. |
Contributor
|
I have tested this item ✅ successfully on 074c694 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26720. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26720. |
Member
|
I have tested this item ✅ successfully on 074c694 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26720. |
Contributor
Author
|
Thanks guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #26691 .
Summary of Changes
Uses new style syntax for the template preview button which correctly sets the title in the the popup modal
Testing Instructions
Open the template preview modal. Before the patch there is a missing title (see image in the original issue). After patch the title now shows and the close button is correctly spaced
Documentation Changes Required
None