[4.0] Make meta description and meta keywords have defaults#26714
Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom Oct 19, 2019
Merged
[4.0] Make meta description and meta keywords have defaults#26714wilsonge merged 3 commits intojoomla:4.0-devfrom
wilsonge merged 3 commits intojoomla:4.0-devfrom
Conversation
- Fixes joomla#26650 - Makes fields optional when creating articles in the API
Contributor
|
I have tested this item ✅ successfully on 28659b4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26714. |
Member
|
I have not tested this item. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26714. |
Member
|
I have tested this item ✅ successfully on 28659b4 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26714. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26714. |
Contributor
Author
|
Thanks guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Makes metakey and metadesc have default values of empty string in the table. Also means these fields aren't required for the API (so I've amended that test to reflect)
Testing Instructions
Disable the Publishing tabset from being displayed in component options. Try and save an article. Before patch you get a warning metakey is required. After patch article saves successfully.
Documentation Changes Required
None