[4.0] Re enable some muted code in Finder#26618
[4.0] Re enable some muted code in Finder#26618wilsonge merged 2 commits intojoomla:4.0-devfrom dgrammatiko:4.0-dev-com_finder
Conversation
|
The last message flashes quickly as the modal closes. Is this the desired behavior? |
Might be the globally applied animations, I didn't notice to be honest... |
|
I have tested this item 🔴 unsuccessfully on 5fb0a6e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618. |
|
@snehaM26 dis you run ‘npm I’? |
|
I have tested this item 🔴 unsuccessfully on 5fb0a6e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618. |
|
I have tested this item 🔴 unsuccessfully on 5fb0a6e This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618. |
|
I have tested this item ✅ successfully on 0c97f8c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618. |
|
I have tested this item ✅ successfully on 0c97f8c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618. |
|
I have tested this item ✅ successfully on 0c97f8c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26618. |
|
Merging. But we should keep an eye on the animations I guess |
Pull Request for Issue # .
Summary of Changes
Note: The
Joomla.ModalAPI is always on the parent window!!!(eg if there is an iframe and you need to call it from there you must call it like:
window.parent.Joomla.Modal.getCurrent().close())Testing Instructions
Run
npm install!importantGo to
http://j4.local/administrator/index.php?option=com_finder&view=indexclick on the Index button
The modal SHOULD close automatically at the end of the indexing process
Expected result
Actual result
Documentation Changes Required
No, cleanup