-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.0] More flexible and null value aware datetime range filter in articles model #26581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wilsonge
merged 9 commits into
joomla:4.0-dev
from
richard67:4.0-dev-articles-model-range-filter
Oct 16, 2019
Merged
[4.0] More flexible and null value aware datetime range filter in articles model #26581
wilsonge
merged 9 commits into
joomla:4.0-dev
from
richard67:4.0-dev-articles-model-range-filter
Oct 16, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonge
approved these changes
Oct 13, 2019
Member
Author
|
@wilsonge Does it need to write testing instructions? Those are the only reason why it is still draft/WiP. I can write tomorrow if necessary. Or would "code review" be enough? |
SharkyKZ
reviewed
Oct 14, 2019
…com/richard67/joomla-cms into 4.0-dev-articles-model-range-filter
Member
Author
|
@SharkyKZ Done. Thanks for the elegant solution you've proposed. I did it that way. |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Follow up to PR #26295 , which introduced real NULL values for datetime columns in com_content's database table.
Extends the range filter for datetimes in the articles model (frontend) so that
Testing Instructions
Code review, or use that datetime filtering of the frontend articles model somewhere.
Expected result
See summary of changes.
Actual result
None of that.
Documentation Changes Required
None as far as I can see.