Skip to content

Conversation

@richard67
Copy link
Member

@richard67 richard67 commented Oct 13, 2019

Pull Request for Issue # .

Summary of Changes

Follow up to PR #26295 , which introduced real NULL values for datetime columns in com_content's database table.

Extends the range filter for datetimes in the articles model (frontend) so that

  1. One of the parameters start and end of the range may be ommitted.
  2. The date to be filtered might be a real NULL value. The filter query will handle that.

Testing Instructions

Code review, or use that datetime filtering of the frontend articles model somewhere.

Expected result

See summary of changes.

Actual result

None of that.

Documentation Changes Required

None as far as I can see.

@richard67 richard67 changed the title [4.0] More flexible datetime range filter in articles model [4.0] [WiP] More flexible and null value aware datetime range filter in articles model Oct 13, 2019
@richard67
Copy link
Member Author

@wilsonge Does it need to write testing instructions? Those are the only reason why it is still draft/WiP. I can write tomorrow if necessary. Or would "code review" be enough?

@richard67 richard67 changed the title [4.0] [WiP] More flexible and null value aware datetime range filter in articles model [4.0] More flexible and null value aware datetime range filter in articles model Oct 13, 2019
@richard67 richard67 marked this pull request as ready for review October 13, 2019 22:23
@richard67
Copy link
Member Author

@SharkyKZ Done. Thanks for the elegant solution you've proposed. I did it that way.

@richard67 richard67 requested a review from wilsonge October 14, 2019 17:36
@wilsonge wilsonge merged commit 13be983 into joomla:4.0-dev Oct 16, 2019
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Oct 16, 2019
@richard67 richard67 deleted the 4.0-dev-articles-model-range-filter branch October 16, 2019 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants