[4.0] Remove deprecated code in Joomla\CMS\Menu\MenuItem

[SharkyKZ]

Pull Request for Issue # .

Summary of Changes

Removes deprecated code from Joomla\CMS\Menu\MenuItem.

Testing Instructions

Install sample data or create some menu items.
Navigate frontend and backend.
Inspect menu items.

Expected result

Works like before.

Documentation Changes Required

Some methods removed.
Added Joomla\CMS\Menu\AdministratorMenuItem class.

[amit4106udale]

I have tested this item 🔴 unsuccessfully on 9137ad0

Error: Cannot access protected property Joomla\CMS\Menu\MenuItem::$params: Cannot access protected property Joomla\CMS\Menu\MenuI

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26537.}

[SharkyKZ]

On which page are you getting this?

[amit4106udale]

On which page are you getting this?

I was testing this on cloudaccess. And applied the patch. Once applied site became black.

[SharkyKZ]

Do you have any 3rd party extensions installed? Maybe using Cloudbase template?

[amit4106udale]

Do you have any 3rd party extensions installed? Maybe using Cloudbase template?

No pure joomla 4 nightly build

[SharkyKZ]

Should work now but don't test yet. Performance could be bad at the moment.

[SharkyKZ]

OK, this can be tested now.

[Quy]

Go to Components Dashboard.

Notice: Undefined property: Joomla\CMS\Menu\MenuItem::$permission in \administrator\modules\mod_submenu\Menu\Menu.php on line 56

Notice: Undefined property: Joomla\CMS\Menu\MenuItem::$icon in \administrator\modules\mod_submenu\tmpl\default.php on line 22

[SharkyKZ]

Though maybe there's a better way to do this. browserNav is a numeric value from database. In some places in backend it's overwritten with the string used in markup. target is only used in backend and it also holds same string. Do we need both of these properties? Maybe remove target and use only browserNav?

In frontend it's much simpler. Only browserNav is used and it does not get overwritten.

[isidrobaq]

I have tested this item ✅ successfully on 0460dd6

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26537.}

[cheiff]

I have tested this item ✅ successfully on 0460dd6

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26537.}

[alikon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26537.}

[wilsonge]

Though maybe there's a better way to do this. browserNav is a numeric value from database. In some places in backend it's overwritten with the string used in markup. target is only used in backend and it also holds same string. Do we need both of these properties? Maybe remove target and use only browserNav?

If that works - and they are exactly the same thing (struggling to tell from a quick code review - I'd probably go down that route. Maybe revert the rename here https://github.com/joomla/joomla-cms/pull/26537/files#diff-1b5557519e9638a5bde91cf3432456dfR403 and then make that change in a separate PR?

[SharkyKZ]

I think it's best to subclass MenuItem for administrator items and add missing properties there.

[wilsonge]

Thanks!

[xillibit]

I have this kind of call in my component :
$params = Factory::getApplication()->getMenu()->getActive()->params; with this change it display : Cannot access protected property Joomla\CMS\Menu\MenuItem::$params

Can-i call instead $params = Factory::getApplication()->getMenu()->getActive()->getParams(); ? getParams() isn't deprecated anymore ?

[SharkyKZ]

Yes, use getParams() to access params.

[bugsmafia]

Error: Cannot access protected property Joomla\CMS\Menu\MenuItem::$params: Cannot access protected property Joomla\CMS\Menu\MenuItem::$params

Are these changes due to a bug on the frontend?

[SharkyKZ]

@bugsmafia Are you using any 3rd party extensions?

[bugsmafia]

@bugsmafia Are you using any 3rd party extensions?

no, clean joomla 4 dev.
Files were updated (developer build of December 16) (with full replacement) after 1 month of development (build of November 7, 2019).

[SharkyKZ]

On which pages does this error occur?

[bugsmafia]

On which pages does this error occur?
Any articles, including the default Featured Articles page
(whether a problem occurs with other components is unknown)

[bugsmafia]

/index.php?option=com_content&view=article&id=2&Itemid=103
Build on November 7th. on the links from the menu to any article gave an error 404.
after updating to the build on December 16th.
"Error: Cannot access protected property Joomla\CMS\Menu\MenuItem::$params: Cannot access protected property Joomla\CMS\Menu\MenuItem::$params"

[SharkyKZ]

I can't replicate this issue on current nightly (https://developer.joomla.org/nightly-builds.html) and on my git clone.

If you upload a zip of your installation (only files, no database), I could take a look.

[bugsmafia]

I can't replicate this issue on current nightly (https://developer.joomla.org/nightly-builds.html) and on my git clone.

If you upload a zip of your installation (only files, no database), I could take a look.

write me bugsmafia@gmai.com or Telegram @bugsm

yep, update only file (full pack),
update structure DB does not fix the error

[bugsmafia]

I Found the source of the problem in my template.
$pageclass = $menu->params->get('pageclass_sfx');
or
$pageclass = $menu->getParams()->get('pageclass_sfx');

[wilsonge]

Documented this https://docs.joomla.org/Potential_backward_compatibility_issues_in_Joomla_4#JMenuItem