Skip to content

Allow int value as ID comparison for module loader #26531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bembelimen wants to merge 4 commits into from
Closed

Allow int value as ID comparison for module loader #26531

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70febc6
Merge pull request #42 from joomla/staging
bembelimen Oct 9, 2019
a1651fd
Allow int value as ID comparison for module loader
bembelimen Oct 9, 2019
eb66f97
Add is_numeric check
bembelimen Oct 18, 2019
5b9a7d6
Cast to string
bembelimen Oct 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/src/Helper/ModuleHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -665,7 +665,7 @@ public static function &getModuleById($id)
for ($i = 0; $i < $total; $i++)
{
// Match the id of the module
if ($modules[$i]->id === $id)
if (is_numeric($id) && $modules[$i]->id === (string) $id)
Copy link
Copy Markdown
Contributor

@SharkyKZ SharkyKZ Oct 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong.

Copy link
Copy Markdown
Contributor

@mbabker mbabker Oct 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How so?

Copy link
Copy Markdown
Contributor

@SharkyKZ SharkyKZ Oct 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both values must be cast as the same type.

Copy link
Copy Markdown
Contributor Author

@bembelimen bembelimen Oct 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$modules[$i]->id is already a string (that's the reason of this PR)

Copy link
Copy Markdown
Contributor

@SharkyKZ SharkyKZ Oct 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it's returned from database. It can be either a string or an integer.

{
// Found it
return $modules[$i];
Expand Down