Skip to content

[4.0] Update null date check in blog layout #26516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2019
Merged

[4.0] Update null date check in blog layout #26516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions layouts/joomla/content/blog_style_default_item_title.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,7 @@
<span class="badge badge-warning"><?php echo Text::_('JNOTPUBLISHEDYET'); ?></span>
<?php endif; ?>

<?php if ($displayData->publish_down != Factory::getDbo()->getNullDate()
&& (strtotime($displayData->publish_down) < strtotime(Factory::getDate()))
) : ?>
<?php if ($displayData->publish_down !== null && strtotime($displayData->publish_down) < strtotime(Factory::getDate())) : ?>
Copy link
Member

@infograf768 infograf768 Oct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normalize code?
In other files it is
<?php if (!is_null($this->item->publish_down)
Don't know what is better.

Copy link
Contributor Author

@SharkyKZ SharkyKZ Oct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strict null comparison is generally faster than is_null(). There's PHP-CS-Fixer rule for removing is_null() uses which we could apply eventually.

Copy link
Member

@richard67 richard67 Oct 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that. Thanks for the info.

<span class="badge badge-warning"><?php echo Text::_('JEXPIRED'); ?></span>
<?php endif; ?>
</div>
Expand Down