Skip to content

Remove @package tag from library doc blocks#26405

Merged
wilsonge merged 3 commits intojoomla:stagingfrom
SharkyKZ:j3/doc/package
Oct 6, 2019
Merged

Remove @package tag from library doc blocks#26405
wilsonge merged 3 commits intojoomla:stagingfrom
SharkyKZ:j3/doc/package

Conversation

@SharkyKZ
Copy link
Contributor

Pull Request for Issue #26395.

Summary of Changes

Removes @package and @subpackage tags from core library files.

Testing Instructions

Code review.

Documentation Changes Required

No.

SharkyKZ added 2 commits September 24, 2019 22:35
@richard67
Copy link
Member

I have tested this item ✅ successfully on 55f08b6

Covers all occurrences of "@Package" or "@subpackage" in PHP files below libraries/src of current staging.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26405.

@Quy
Copy link
Contributor

Quy commented Sep 25, 2019

I have tested this item ✅ successfully on 55f08b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26405.

@Quy
Copy link
Contributor

Quy commented Sep 25, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26405.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 25, 2019
@richard67
Copy link
Member

What about the PHCS sniffer thing which Michael suggested in his issue in order to avoid such doc block content in future? Does anyone have the knowledge and mood and time to do that?

@SharkyKZ
Copy link
Contributor Author

I can find time and maybe even mood but have no knowledge 😕

@SharkyKZ
Copy link
Contributor Author

Scribbled something up joomla/coding-standards#255.

@wilsonge wilsonge merged commit 9c437d0 into joomla:staging Oct 6, 2019
@wilsonge
Copy link
Contributor

wilsonge commented Oct 6, 2019

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 6, 2019
@wilsonge wilsonge added this to the Joomla! 3.9.13 milestone Oct 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants