Skip to content

Remove unused variable#26361

Merged
wilsonge merged 1 commit intojoomla:3.10-devfrom
Quy:remove-variable
Oct 19, 2019
Merged

Remove unused variable#26361
wilsonge merged 1 commit intojoomla:3.10-devfrom
Quy:remove-variable

Conversation

@Quy
Copy link
Contributor

@Quy Quy commented Sep 19, 2019

Summary of Changes

Remove $fullWidth as it is not being used.

Testing Instructions

Code review.

@richard67
Copy link
Member

I have tested this item ✅ successfully on df6cc4b

I can confirm that the variable is not used anywhere in J3 core.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26361.

@alikon
Copy link
Contributor

alikon commented Sep 19, 2019

I have tested this item ✅ successfully on df6cc4b

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26361.

@alikon
Copy link
Contributor

alikon commented Sep 19, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26361.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 19, 2019
@brianteeman
Copy link
Contributor

I am wary of this being committed in a patch release

@alikon
Copy link
Contributor

alikon commented Sep 19, 2019

i'm afraid we will only have 3.10 .... what i'm missing ?

@infograf768 infograf768 added this to the Joomla 3.10.0 milestone Sep 20, 2019
@SharkyKZ
Copy link
Contributor

It's just a local variable. Fine to go in 3.9.xx.

@infograf768
Copy link
Member

As we have been living with it since 3.0.0 without any side effects and @HLeithner wants to minimize changes in the stable vs RC, let's just merge in 3.10.0 ;)

@wilsonge wilsonge changed the base branch from staging to 3.10-dev October 19, 2019 21:31
@wilsonge wilsonge merged commit 96e8e0d into joomla:3.10-dev Oct 19, 2019
@joomla-cms-bot joomla-cms-bot added PR-3.10-dev and removed RTC This Pull Request is Ready To Commit labels Oct 19, 2019
@wilsonge
Copy link
Contributor

Thanks!

@Quy Quy deleted the remove-variable branch November 13, 2019 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants