Skip to content

[4.0] Fix switcher position.#26360

Merged
wilsonge merged 4 commits intojoomla:4.0-devfrom
Harmageddon:fix_switcher_position
Oct 16, 2019
Merged

[4.0] Fix switcher position.#26360
wilsonge merged 4 commits intojoomla:4.0-devfrom
Harmageddon:fix_switcher_position

Conversation

@Harmageddon
Copy link
Contributor

Testing Instructions

  1. Navigate to "System - Site Templates - Cassiopeia Details and Files".
  2. Create an override for a component view.
  3. Edit the override.
  4. Look at the switcher in disabled and enabled state.
  5. Apply the PR.
  6. Make sure that the switcher still looks correctly in other places, like com_config.

Expected result

Screenshot_2019-09-19 Templates Customise (Cassiopeia) - Joomla 4 Git - Administration

Actual result

Screenshot_2019-09-19 Templates Customise (Cassiopeia) - Joomla 4 Git - Administration broken

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 19, 2019
@Harmageddon Harmageddon changed the title Fix switcher position. [4.0] Fix switcher position. Sep 19, 2019
@richard67
Copy link
Member

I have tested this item ✅ successfully on c934732


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26360.

@eXsiLe95
Copy link
Contributor

I have tested this item ✅ successfully on c934732


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26360.

1 similar comment
@infograf768
Copy link
Member

I have tested this item ✅ successfully on c934732


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26360.

@joomla-cms-bot joomla-cms-bot removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 21, 2019
@alikon
Copy link
Contributor

alikon commented Sep 21, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26360.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 21, 2019
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Sep 24, 2019
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 16, 2019
@zero-24 zero-24 added this to the Joomla 4.0 milestone Oct 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants