Skip to content

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Sep 7, 2019

Summary of Changes

Dont break com_config and the installer on update

Testing Instructions

first test

  • Install 4.0-alpha12-dev on windows
  • confirm that com_config works (system -> Global configuration)
  • conform that the installer code is still there as expected
  • got to system -> Update -> Joomla -> Live Update
  • reinstall core files
  • notice that the installer code is gone
  • notice that com_config is broken (windows systems only)

second test

Expected result

Installer is still there & com_config is not broken

Actual result

installer is gone & com_config is broken on windows systems

Documentation Changes Required

none

Next steps

- [ ] set that folders to the blacklist in the build script https://github.com/joomla/joomla-cms/blob/staging/build/deleted_file_check.php

@mbabker
Copy link
Contributor

mbabker commented Sep 7, 2019

There shouldn't be a blacklist in that script. The entire intent is to write out a list of deleted files between any two git references. It's up to whomever is using the file that script generates to decide what to do with the data, which means reviewing it and not just copy/pasting the entire file into the com_admin script.

@zero-24
Copy link
Contributor Author

zero-24 commented Sep 7, 2019

ok thanks just maked it as obsolte than :)

@wilsonge
Copy link
Contributor

There needs to be a blacklist in my new script that i used to generate this however - because it's doing directory iterations https://github.com/joomla/joomla-cms/pull/25559/files

@SharkyKZ
Copy link
Contributor

Is this supposed to solve #25531?

@SharkyKZ
Copy link
Contributor

This is fine when updating between 4.0 versions. But not when upgrading from 3.x.

@ceford
Copy link
Contributor

ceford commented Dec 13, 2019

I experience this with J4 beta1-dev - after update folders are missing from com_config. A temporary solution is to copy com_config from an expanded package zip file.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26202.

@wilsonge
Copy link
Contributor

Installation fixes will be solved by #25559 and com_config probably needs a better fix because on linux systems we won't clean up properly the old j3 directories after this is applied so closing this. com_config issue still needs to be solved and tracked in #25531

@wilsonge wilsonge closed this Jan 11, 2020
@zero-24 zero-24 deleted the dont_break_config_installer branch January 11, 2020 07:46
@zero-24
Copy link
Contributor Author

zero-24 commented Jan 11, 2020

@wilsonge when we don't want to apply this workaround until we have a final version than please mention this issue in the release notes so everyone is aware of this issue.

@wilsonge
Copy link
Contributor

#27481 com_config proper patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants