Skip to content

Make sure passing an boolean does silently work like before in JRoute::_#26089

Merged
HLeithner merged 2 commits intojoomla:stagingfrom
zero-24:router_bc
Sep 17, 2019
Merged

Make sure passing an boolean does silently work like before in JRoute::_#26089
HLeithner merged 2 commits intojoomla:stagingfrom
zero-24:router_bc

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Aug 30, 2019

Pull Request for Issue #26087

Summary of Changes

Make sure passing an boolean does silently work like before cc @HLeithner #25225

Testing Instructions

echo JRoute::_('index.php', false, true)."\n";  //returns http:
echo JRoute::_('index.php', false, false)."\n"; //returns relative
echo JRoute::_('index.php', false, 1)."\n"; //return https:
echo JRoute::_('index.php', false, '1')."\n"; //returns https:
echo JRoute::_('index.php', false, JROUTE::TLS_DISABLE)."\n"; debug_zval_dump(JROUTE::TLS_DISABLE); //returns http: 
echo JRoute::_('index.php', false, JROUTE::TLS_FORCE)."\n"; debug_zval_dump(JROUTE::TLS_FORCE);  //returns https:
echo JRoute::_('index.php', false, JROUTE::TLS_IGNORE)."\n"; debug_zval_dump(JROUTE::TLS_IGNORE);  //returns relative

Expected result

echo JRoute::_('index.php', false, true)."\n";  //returns https:
echo JRoute::_('index.php', false, -1)."\n"; //return http:

Actual result

echo JRoute::_('index.php', false, true)."\n";  //returns http:
echo JRoute::_('index.php', false, -1)."\n"; //return http:

Documentation Changes Required

none.

@wilsonge
Copy link
Contributor

@HLeithner you need to review this as it's a 3.x regression

@HLeithner HLeithner merged commit 0fb0e41 into joomla:staging Sep 17, 2019
@HLeithner
Copy link
Member

Thanks for fix this b/c break.

@zero-24 zero-24 deleted the router_bc branch September 22, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants