Make sure passing an boolean does silently work like before in JRoute::_#26089
Merged
HLeithner merged 2 commits intojoomla:stagingfrom Sep 17, 2019
Merged
Make sure passing an boolean does silently work like before in JRoute::_#26089HLeithner merged 2 commits intojoomla:stagingfrom
HLeithner merged 2 commits intojoomla:stagingfrom
Conversation
wilsonge
reviewed
Sep 2, 2019
wilsonge
approved these changes
Sep 3, 2019
Contributor
|
@HLeithner you need to review this as it's a 3.x regression |
Member
|
Thanks for fix this b/c break. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #26087
Summary of Changes
Make sure passing an boolean does silently work like before cc @HLeithner #25225
Testing Instructions
Expected result
Actual result
Documentation Changes Required
none.