[4.0] Adding error handling for installer#26073
Closed
Hackwar wants to merge 5 commits intojoomla:4.0-devfrom
Closed
[4.0] Adding error handling for installer#26073Hackwar wants to merge 5 commits intojoomla:4.0-devfrom
Hackwar wants to merge 5 commits intojoomla:4.0-devfrom
Conversation
…4installerrors # Conflicts: # installation/template/js/setup.js # installation/template/js/template.js
Contributor
|
I have tested this item ✅ successfully on 725af51 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26073. |
|
Tested successfully ✅ |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26073. |
Contributor
|
Kinda unconvinced by blatting out the raw code from an end user perspective. Can we not just give that message without appending the text and |
Quy
added
the
Updates Requested
wilsonge
pushed a commit
that referenced
this pull request
Nov 30, 2019
Contributor
|
I've pushed a modified version of this with the changes I requested above |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the ajax requests during installation are failing, we currently get no feedback about that in the UI. This PR adds some error handling for that. This is not perfect, but better than nothing and maybe someone can help make this better.
Testinstructions
echo 'something';at line 74 (This breaks the response and triggers the error)Install Joomla