Delete wrong check for the no download message

[zero-24]

Pull Request for Issue #25827

Summary of Changes

Make sure no download message is displayed in any case when the download URL is not set

Testing Instructions

• install 3.9.12-dev (https://developer.joomla.org/nightlies/Joomla_3.9.12-dev-Development-Full_Package.zip)
• apply this custom update server: https://www.jah-tz.de/downloads/core/nightlies/next_minor_list.xml
• try to get an update
• see the errors from Undefined property: Joomla\CMS\Updater\Update::$downloadurl #25827
• apply this patch
• check for updates again
• no download message is displayed

Expected result

No download message is displayed.

Actual result

PHP Notice:  Undefined property: Joomla\CMS\Updater\Update::$downloadurl in \administrator\components\com_joomlaupdate\views\default\tmpl\default_reinstall.php on line 34
PHP Notice:  Trying to get property '_data' of non-object in \administrator\components\com_joomlaupdate\views\default\tmpl\default_reinstall.php on line 34
PHP Notice:  Undefined property: Joomla\CMS\Updater\Update::$downloadurl in \administrator\components\com_joomlaupdate\views\default\tmpl\default_reinstall.php on line 35
PHP Notice:  Trying to get property '_data' of non-object in \administrator\components\com_joomlaupdate\views\default\tmpl\default_reinstall.php on line 35

Documentation Changes Required

None.

[richard67]

@zero-24 URL of custom update server missing in description.

[zero-24]

ha :D Fixed it is: https://www.jah-tz.de/downloads/core/nightlies/next_minor_list.xml

[richard67]

I have tested this item ✅ successfully on a97466e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25924.}

[richard67]

Hint for other testers: You can also test with current staging on a cloned GitHub repo, no need do download and install 3.9.12-dev nightly build.

[zero-24]

Thanks for your test @richard67 and yes staging works too but is not required 👍

[richard67]

Yes, whatever is easier because available.

[viocassel]

I have tested this item ✅ successfully on a97466e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25924.}

[ghost]

Status "Ready To Commit".

[HLeithner]

Thank you for bringing some love to the Joomla update system.