Skip to content

Catch broken confirmConsent configuration#25858

Merged
HLeithner merged 2 commits intojoomla:stagingfrom
zero-24:confirmConsent
Aug 22, 2019
Merged

Catch broken confirmConsent configuration#25858
HLeithner merged 2 commits intojoomla:stagingfrom
zero-24:confirmConsent

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Aug 15, 2019

Pull Request for Issue raised here: https://forum.joomla.de/thread/8188-dsgvo-anfrageformular-bringt-fehlermeldung/ (german)

Summary of Changes

Make sure there is an article object. When not forward to an 404 error as the article ID does not exists.

Testing Instructions

configure confirm consent
show it in the frontend
remove the article
try to show it in the frontend again

Expected result

404

Actual result

Notice: Trying to get property 'id' of non-object in /plugins/content/confirmconsent/fields/consentbox.php on line 252
Notice: Trying to get property 'language' of non-object in /plugins/content/confirmconsent/fields/consentbox.php on line 255
Notice: Trying to get property 'id' of non-object in /plugins/content/confirmconsent/fields/consentbox.php on line 269
Notice: Trying to get property 'catid' of non-object in /plugins/content/confirmconsent/fields/consentbox.php on line 269
Notice: Trying to get property 'language' of non-object in /plugins/content/confirmconsent/fields/consentbox.php on line 270

Documentation Changes Required

none

@ChristineWk
Copy link

Confirm "Actual Result". After Patch: error 404 of previous removed article.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25858.

@ChristineWk
Copy link

I have tested this item ✅ successfully on 6c9605a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25858.

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 20, 2019

Thanks @ChristineWk for your tests 👍

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 6c9605a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25858.

@Quy Quy removed the PR-staging label Aug 21, 2019
@Quy
Copy link
Contributor

Quy commented Aug 21, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25858.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 21, 2019
@ghost
Copy link

ghost commented Aug 21, 2019

Status "Ready To Commit".

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 21, 2019

Thanks 👍

@zero-24 zero-24 added this to the Joomla! 3.9.12 milestone Aug 21, 2019
@HLeithner
Copy link
Member

Thank you very much for this failsafe.

@HLeithner HLeithner merged commit 8ec7c64 into joomla:staging Aug 22, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 22, 2019
@zero-24 zero-24 deleted the confirmConsent branch August 23, 2019 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants