Catch broken confirmConsent configuration#25858
Merged
HLeithner merged 2 commits intojoomla:stagingfrom Aug 22, 2019
Merged
Conversation
|
Confirm "Actual Result". After Patch: error 404 of previous removed article. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25858. |
|
I have tested this item ✅ successfully on 6c9605a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25858. |
Contributor
Author
|
Thanks @ChristineWk for your tests 👍 |
Contributor
|
I have tested this item ✅ successfully on 6c9605a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25858. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25858. |
|
Status "Ready To Commit". |
Contributor
Author
|
Thanks 👍 |
Member
|
Thank you very much for this failsafe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue raised here: https://forum.joomla.de/thread/8188-dsgvo-anfrageformular-bringt-fehlermeldung/ (german)
Summary of Changes
Make sure there is an article object. When not forward to an 404 error as the article ID does not exists.
Testing Instructions
configure confirm consent
show it in the frontend
remove the article
try to show it in the frontend again
Expected result
404
Actual result
Documentation Changes Required
none