Make com_joomlaupdate info and download URL opening a new page#25848
Make com_joomlaupdate info and download URL opening a new page#25848HLeithner merged 4 commits intojoomla:stagingfrom
Conversation
|
The reason that we did not put In addition if you insist on the links opening in a new window then you must add information that the link opens in a new window. |
In some cases we might use external sites like github too and IIRC it does not hurt right?
Any suggestion how? IIRC we have an css class for this? Or do you think we should do it different? |
|
No doesnt hurt try something like < span class = sr-only > opens in a new window </ span |
Do we already have an example / string in core for this so we are reinventing the wheel here also does this need to go in staging as this is a PR against staging? |
|
Please check the latest commits @brianteeman @Quy |
administrator/components/com_joomlaupdate/views/default/tmpl/default_reinstall.php
Outdated
Show resolved
Hide resolved
|
I have tested this item ✅ successfully on ecc9606 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25848. |
1 similar comment
|
I have tested this item ✅ successfully on ecc9606 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25848. |
|
Status "Ready To Commit". |
|
Thank you for making Joomla ux better. |
Pull Request for Issue raised by Michael Melson on Facebook
Summary of Changes
Make sure the download URL and info URL opens as a new page.
Testing Instructions
click the update URL or the info url
Expected result
new page opens as it is a remote site
Actual result
the current page is closed and the new page is open in the same tab.
Documentation Changes Required
none