[plg_system_cache] Disable gzip before caching the page#25823
Merged
HLeithner merged 3 commits intojoomla:stagingfrom Aug 23, 2019
SharkyKZ:j3/gzipCache
Merged
[plg_system_cache] Disable gzip before caching the page#25823HLeithner merged 3 commits intojoomla:stagingfrom SharkyKZ:j3/gzipCache
HLeithner merged 3 commits intojoomla:stagingfrom
SharkyKZ:j3/gzipCache
Conversation
Member
|
|
Member
|
I have tested this item ✅ successfully on 6c8c523 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25823. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 6c8c523 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25823. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25823. |
Member
|
Thank you for fixing the cache. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #17501.
Summary of Changes
Makes sure we store uncompressed page in cache.
Testing Instructions
Enable
Gzip Compressionin Global Configuration.Enable
System - Page Cacheplugin.Open some cacheable frontend page with a form, e.g. username reminder page. Remember its URL.
Start a new session (e.g. clear browser session or use a different browser).
Open the same page and try to submit form.
Expected result
Form submitted.
Actual result
Submitting form fails with warning:
Documentation Changes Required
No.