Skip to content

[plg_system_cache] Disable gzip before caching the page#25823

Merged
HLeithner merged 3 commits intojoomla:stagingfrom
SharkyKZ:j3/gzipCache
Aug 23, 2019
Merged

[plg_system_cache] Disable gzip before caching the page#25823
HLeithner merged 3 commits intojoomla:stagingfrom
SharkyKZ:j3/gzipCache

Conversation

@SharkyKZ
Copy link
Contributor

Pull Request for Issue #17501.

Summary of Changes

Makes sure we store uncompressed page in cache.

Testing Instructions

Enable Gzip Compression in Global Configuration.
Enable System - Page Cache plugin.
Open some cacheable frontend page with a form, e.g. username reminder page. Remember its URL.
Start a new session (e.g. clear browser session or use a different browser).
Open the same page and try to submit form.

Expected result

Form submitted.

Actual result

Submitting form fails with warning:

The security token did not match. The request was aborted to prevent any security breach. Please try again.

Documentation Changes Required

No.

@richard67
Copy link
Member

richard67 commented Aug 12, 2019

Will the page from the cache be served zipped or unzipped?
Update: Looks as if the browser still gets the cached page compressed => good.

@richard67
Copy link
Member

I have tested this item ✅ successfully on 6c8c523


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25823.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 6c8c523


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25823.

@Quy
Copy link
Contributor

Quy commented Aug 12, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25823.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 12, 2019
@HLeithner
Copy link
Member

Thank you for fixing the cache.

@HLeithner HLeithner merged commit 92aff72 into joomla:staging Aug 23, 2019
@HLeithner HLeithner added this to the Joomla! 3.9.12 milestone Aug 23, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants