Improve hasUpdate checks and make sure we don't offer updates to outdated versions

[zero-24]

Summary of Changes

Improve hasUpdate checks and make sure we don't offer downgrades to outdated versions

Testing Instructions

• check for updates
• go to the database table #__updates
• manually change the core update versions collum to a lower version than the current.
• go to the updater page (don't hit refresh)
• see the message to update to an lower version than installed

Expected result

When we have an old version in the cache joomla says it runs the latest version

Actual result

When we have an older version in the cache Joomla wants to update to that version.

Documentation Changes Required

none

Additional info

The behavior we build by manually changing the database table can happen in case there is some caching of the old version of the update for some reason. one of many examples (german): https://forum.joomla.de/thread/8109-joomla-update-wird-nicht-angeboten-bzw-falsches-update-3-9-10/

[mbabker]

Use version_compare() with three arguments, i.e. version_compare($updateObject->version, JVERSION, '<='). I've been writing PHP for 10 years and I couldn't tell you a thing about any of the return values of version_compare(), whereas specifying the comparison as the third parameter makes it crystal clear what you're intending here.

[zero-24]

has been patched thanks 👍

[richard67]

I have tested this item ✅ successfully on a5f0ef2

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25810.}

[alikon]

I have tested this item ✅ successfully on a5f0ef2

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25810.}

[alikon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25810.}

[richard67]

I have tested this item ✅ successfully on dcf8c97

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25810.}

[richard67]

Last change was only a code comment correction so @alikon 's test result is still valid.

[HLeithner]

Thank you for stop downgrading offers.