Skip to content

Support minimum stability for com_joomlaupdate#25809

Merged
rdeutz merged 10 commits intojoomla:stagingfrom
zero-24:supportMinimumStabilityForCoreToo
Sep 1, 2019
Merged

Support minimum stability for com_joomlaupdate#25809
rdeutz merged 10 commits intojoomla:stagingfrom
zero-24:supportMinimumStabilityForCoreToo

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Aug 10, 2019

Summary of Changes

Implement support for minimum stability for the core.

Testing Instructions

  • Switch to the testing update server (as of writing this it points to an RC update)
  • check for updates
  • no downlaods found message
  • apply patch
  • switch mimimum stablilty to RC in the updater config
  • check for updates again.

Expected result

Joomla offeres the RC version to update

Actual result

image

Documentation Changes Required

New option needs to be added to the com_joomlaupdate config docs page.

Additional changes

  • alpha order the language strings in com_joomlaupdate
  • extend the list of possible issues for no download URL with minimum stability
  • shorten the generation of $cache_timeout into one line.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Aug 10, 2019
Co-Authored-By: Brian Teeman <brian@teeman.net>
Co-Authored-By: Brian Teeman <brian@teeman.net>
@@ -128,11 +133,11 @@ public function refreshUpdates($force = false)
if (count($methodParameters) >= 4)
{
// Reinstall support is available in JUpdater
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this comment correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not? the latest com_joomlaupdate can be installed on accident jomla versions not supporting that feature.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesnt seem to be relevant to that code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain what you mean by that? The code mention checks whether there is support for the reinstall attribute or not and handle that case differently. In the line just after this comment it calls the new signature so to me this is still perfectly valid.

But I'm fine to change the text on your suggestion if required.

@ghost ghost changed the title [3.9] Support minimum stability for com_joomlaupdate Support minimum stability for com_joomlaupdate Aug 11, 2019
@twister65
Copy link
Contributor

I have tested this item ✅ successfully on d9afae8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25809.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on d9afae8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25809.

@ghost
Copy link

ghost commented Aug 12, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 12, 2019
@rdeutz rdeutz merged commit 00cd975 into joomla:staging Sep 1, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 1, 2019
@zero-24 zero-24 deleted the supportMinimumStabilityForCoreToo branch September 1, 2019 19:31
@zero-24
Copy link
Contributor Author

zero-24 commented Sep 1, 2019

Thanks for the merge and the tests 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants