Support minimum stability for com_joomlaupdate#25809
Conversation
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Brian Teeman <brian@teeman.net>
Co-Authored-By: Brian Teeman <brian@teeman.net>
| @@ -128,11 +133,11 @@ public function refreshUpdates($force = false) | |||
| if (count($methodParameters) >= 4) | |||
| { | |||
| // Reinstall support is available in JUpdater | |||
There was a problem hiding this comment.
is this comment correct?
There was a problem hiding this comment.
why not? the latest com_joomlaupdate can be installed on accident jomla versions not supporting that feature.
There was a problem hiding this comment.
it doesnt seem to be relevant to that code
There was a problem hiding this comment.
Can you please explain what you mean by that? The code mention checks whether there is support for the reinstall attribute or not and handle that case differently. In the line just after this comment it calls the new signature so to me this is still perfectly valid.
But I'm fine to change the text on your suggestion if required.
|
I have tested this item ✅ successfully on d9afae8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25809. |
1 similar comment
|
I have tested this item ✅ successfully on d9afae8 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25809. |
|
Status "Ready To Commit". |
|
Thanks for the merge and the tests 👍 |
Summary of Changes
Implement support for minimum stability for the core.
Testing Instructions
no downlaods foundmessageExpected result
Joomla offeres the RC version to update
Actual result
Documentation Changes Required
New option needs to be added to the com_joomlaupdate config docs page.
Additional changes