[4.0] Installation - create a name #25774
Conversation
For historical reasons that I bet no one can remember Joomla doesn't currently let you enter the real name of the Super User when installing Joomla. As a result every site on installation has a user with the name "Super User". This regularly causes issues as it gets confused with the usergroup "Super Users". That might be a translation issue or simply because there is just one character difference I don't know and it doesnt really matter. As today there is no valid reason to force the name to be "Super User" and this PR prompts for the real name as well as the username during installation. ### To test. Apply this PR using patchtester. delete configuration.php re-install joomla (Please no bikeshedding about other issues in the installer)
|
Make the real name required? |
|
oops I meant to do that - even if the entire required thing is foobar |
|
It makes sense to me that this is failing the tests. Do I submit the pr to fix that here https://github.com/joomla-projects/joomla-browser/blob/develop/src/JoomlaBrowser.php |
|
v4.0.0 branch rather than develop but yes. relevent code is here https://github.com/joomla-projects/joomla-browser/blob/v4.0.0/src/JoomlaBrowser.php#L241-L247 |
|
See joomla-projects/joomla-browser#186 for the tests |
|
merged. can you update the composer dependency here please?
|
|
Updated as requested |
|
I have tested this item ✅ successfully on 5919cdf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25774. |
|
Tested new install with MySQL 5.7 and PostgreSQL 10.9. Thanks for this PR. It was time that it was done. One step less to do after a new installation. |
|
I have tested this item ✅ successfully on 5919cdf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25774. |
|
Looks like you made a slight mistake in the system tests jform_admin_name but in the xml there your is is jform_admin_user you need to either update the tests or the xml so they match |
|
@wilsonge corrected and merged. Do I have to update composer again? |
|
I assume I do so I did |
|
I have tested this item ✅ successfully on ade86cb This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25774. |
|
You did. Looks happy now! |
|
Thanks! |
|
Great - thanks |
7 participants
For historical reasons that I bet no one can remember Joomla doesn't currently let you enter the real name of the Super User when installing Joomla. As a result every site on installation has a user with the name "Super User". This regularly causes issues as it gets confused with the usergroup "Super Users". That might be a translation issue or simply because there is just one character difference I don't know and it doesnt really matter.
As today there is no valid reason to force the name to be "Super User" this PR prompts for the real name as well as the username during installation.
To test.
Apply this PR using patchtester.
delete configuration.php
re-install joomla
(Please no bikeshedding about other issues in the installer)