Skip to content

Conversation

@richard67
Copy link
Member

Pull Request for Issue #25385 .

Summary of Changes

Add admin paths to the search paths for form and its fields for loading the configuration form for frontend editing of site configuration options.

Testing Instructions

Create a menu type "Configuration manager", "Site Configuration options", access "Super User". Go to FrontEnd and log as superuser. Site Configutration is displayed and may be updated. Click on Save button.

Expected result

Configuration saved.

Actual result

Error 0 - Call to a member function filter() on boolean.

Documentation Changes Required

None.

Copy link
Contributor

@conseilgouz conseilgouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine for me.

Thank you

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Jul 2, 2019

Seems to work. Just got to wonder what caused this to break or how long it was broken.

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Jul 2, 2019

I have tested this item ✅ successfully on ee9f9eb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25404.

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Jul 2, 2019

@pmleconte please submit your test result https://docs.joomla.org/Testing_Joomla!_patches.

@richard67
Copy link
Member Author

@pmleconte Could you mark your test result as successful on https://issues.joomla.org/tracker/joomla-cms/25404 by using the "Test this" button?

@richard67
Copy link
Member Author

richard67 commented Jul 2, 2019

@SharkyKZ Was broken since 3.9.4, see link at the bottom of the issue description in #25385 . It seems the function is not used very often by people, or they don't report issues here so often ;-)

@conseilgouz
Copy link
Contributor

I have tested this item ✅ successfully on ee9f9eb

Ok for me


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25404.

@ghost
Copy link

ghost commented Jul 2, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 2, 2019
@HLeithner
Copy link
Member

thx

@HLeithner HLeithner merged commit 79de916 into joomla:staging Jul 2, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 2, 2019
@HLeithner HLeithner added this to the Joomla 3.9.9 milestone Jul 2, 2019
@richard67 richard67 deleted the staging-fix-frontend-config-save branch July 2, 2019 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants