Skip to content

Subform - Wrong ID generated for the elements of subform when we click on Plus (+) button to add repeated subform #25387 #25398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 2, 2019
Merged

Subform - Wrong ID generated for the elements of subform when we click on Plus (+) button to add repeated subform #25387 #25398

Changes from 6 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
41ddccf
Fix for issue with ID #22586 :- Show action logs for guest users as w…
ankushmaherwal Oct 11, 2018
07a77e8
Merge pull request #1 from cheetabhai/cheetabhai-patch-ID-22586
ankushmaherwal Oct 15, 2018
df4a01c
Merge branch 'staging' of https://github.com/joomla/joomla-cms into s…
ankush-maherwal Jul 2, 2019
2c8799a
Subform - Wrong ID generated for the elements of subform when we clic…
ankush-maherwal Jul 2, 2019
3dc5657
Subform - Wrong ID generated for the elements of subform when we clic…
ankush-maherwal Jul 2, 2019
3e7d9c9
Subform - Wrong ID generated for the elements of subform when we clic…
ankush-maherwal Jul 2, 2019
772b9b8
Subform - Wrong ID generated for the elements of subform when we clic…
ankush-maherwal Jul 2, 2019
94328cc
Subform - Wrong ID generated for the elements of subform when we clic…
ankush-maherwal Jul 2, 2019
9570c0d
Merge branch 'staging' of https://github.com/joomla/joomla-cms into s…
ankush-maherwal Jul 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion media/system/js/subform-repeatable-uncompressed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@
for (var i = 0, l = haveName.length; i < l; i++) {
var $el = $(haveName[i]),
name = $el.attr('name'),
id = name.replace(/(\[\]$)/g, '').replace(/(\]\[)/g, '__').replace(/\[/g, '_').replace(/\]/g, ''), // id from name
id = name.replace(/(\[\]$)/g, '').replace(/(\]\[)/g, '__').replace(/\[/g, '_').replace(/\]/g, '').replace(/\W/g,"_"), // id from name
Copy link
Contributor

@SharkyKZ SharkyKZ Jul 2, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codestyle.

Suggested change
id = name.replace(/(\[\]$)/g, '').replace(/(\]\[)/g, '__').replace(/\[/g, '_').replace(/\]/g, '').replace(/\W/g,"_"), // id from name
id = name.replace(/(\[\]$)/g, '').replace(/(\]\[)/g, '__').replace(/\[/g, '_').replace(/\]/g, '').replace(/\W/g, '_'), // id from name

Copy link

@ankush-maherwal ankush-maherwal Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the Codestyle

nameNew = name.replace('[' + group + '][', '['+ groupnew +']['), // New name
idNew = id.replace(group, groupnew), // Count new id
countMulti = 0, // count for multiple radio/checkboxes
Expand Down