[4.0] Enable utf8mb4 connections for mysql adapters on installation#25292
Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom Jun 22, 2019
Merged
[4.0] Enable utf8mb4 connections for mysql adapters on installation#25292wilsonge merged 2 commits intojoomla:4.0-devfrom
wilsonge merged 2 commits intojoomla:4.0-devfrom
Conversation
Member
Author
|
Ping @wilsonge 😄 |
Member
Author
|
@mbabker If you have a bit time, could you check if this PR is an acceptable way to solve the issue we recently discussed? It works, but if you think it's an ugly hack, I will close it of course. |
Contributor
|
That's how it should be. The key part is in making sure the right options always get passed into the drivers, which this PR fixes. |
Contributor
|
Thanks! |
Member
Author
|
Thanks too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for issue described below.
Summary of Changes
This is the same as PR #24704 but for the installation.
Testing Instructions
Expected result
No database error, all tables are created with utf8mb4 charset and collations.
Actual result
One database error about tables not having been converted to utf8mb4, all tables are created with utf8 charset and collations.
What is funny: When connecting to the backend after installation, connection shows utf8mb4 support.
But using the "fix" button to run the utf8mb4 conversion does not help (which makes sense because 4.0 should have all converted already), so you have to live with that database error and wrong collation in db until the end of your life.
When using the MySQLi driver, everything is ok, i.e. this issue is only for the MySQL PDO driver.
But this might be just lucky circumstance, or to be more precise, inconsistency between the drivers regarding initial value for utf8mb4 support, and so this PR also adds the right default for the MySQLi driver.
At the end it is just the same for the installation as PR #24704 was for the installed J4.
With staging this issue does not exist, it exists only in 4.0-dev.
Documentation Changes Required
None.