Contact and Newsfeed title not incremented during batch copy

[SharkyKZ]

Pull Request for Issue #25255.

Summary of Changes

Set title column alias in ContactTable and NewsfeedTable table.
Use column aliases in Joomla\CMS\MVC\Model\AdminModel::generateTitle() and Joomla\CMS\MVC\Model\AdminModel::generateNewTitle().

Testing Instructions

Go to contacts or newsfeeds list in backend.
Select a contact/newsfeed.
Click Batch button.
Perform batch copy to the same category.

Expected result

Contact/newsfeed title incremented, e.g. Sample Contact becomes Sample Contact (2).

Actual result

Contact/newsfeed title not incremented.

Documentation Changes Required

No.

[richard67]

I have tested this item ✅ successfully on 13bc80c

Works as described.

With articles and other stuff the title is already incremented before this PR, so this PR makes the functionality consistent also for contacts and newsfeeds.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25259.}

[richard67]

I have not tested this item.

Hmm, I get:

[Tue Jun 18 20:54:06.411713 2019] [php7:notice] [pid 6007] [client 192.168.98.1:60754] PHP Notice: Undefined property: ContactTableContact::$title in /home/richard/lamp/public_html/joomla-cms/libraries/src/MVC/Model/AdminModel.php on line 1534, referer: https://www.joomla.vmnet2.local/administrator/index.php?option=com_contact
[Tue Jun 18 20:54:44.544675 2019] [php7:notice] [pid 6019] [client 192.168.98.1:60758] PHP Notice: Undefined property: NewsfeedsTableNewsfeed::$title in /home/richard/lamp/public_html/joomla-cms/libraries/src/MVC/Model/AdminModel.php on line 1534, referer: https://www.joomla.vmnet2.local/administrator/index.php?option=com_newsfeeds

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25259.}

[richard67]

I have tested this item ✅ successfully on 13bc80c

Me idiot. PHP notice undefined property was BEFORE the PR was applied 😄

PR works as described.

With articles and other stuff the title is already incremented before this PR, so this PR makes the functionality consistent also for contacts and newsfeeds.

In addition, it makes the PHP Notice: Undefined property: ContactTableContact::$title and PHP Notice: Undefined property: NewsfeedsTableNewsfeed::$title not happen anymore when batch copying contacts or newsfeeds.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25259.}

[richard67]

@Quy Just when you had finished typing I had noticed that, too 😄

[Quy]

I have tested this item ✅ successfully on 13bc80c

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25259.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25259.}

[alikon]

proud of you guys, not so common behaviour to admit a momentary lapse of fault

[richard67]

For me it is normal behavior.

[wilsonge]

Thanks!