Skip to content

Conversation

@Hackwar
Copy link
Member

@Hackwar Hackwar commented Jun 16, 2019

Hopefully makeing Appveyor happy again.

@zero-24
Copy link
Contributor

zero-24 commented Jun 16, 2019

When this helps we should also patch this upstream in the string package: https://github.com/joomla-framework/string/blob/master/src/phputf8/utf8.php#L45 it seams some other changes have been done there in the meantime too.

@richard67
Copy link
Member

It seems before making Appveyor happy it needs to wake him up.

@richard67
Copy link
Member

Hooray, appveyor passed with success!!!

@richard67
Copy link
Member

I have tested this item ✅ successfully on 264fd78

Before this PR, Appveyor tests failed here:
https://github.com/joomla/joomla-cms/blob/staging/libraries/vendor/joomla/string/src/phputf8/utf8.php#L38
with error

Warning: A non-numeric value encountered in C:\projects\joomla-cms\libraries\vendor\joomla\string\src\phputf8\utf8.php on line 38

With this PR is passes.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25234.

@richard67
Copy link
Member

@zero-24 PR for framwork package see joomla-framework/string#22.

@richard67
Copy link
Member

richard67 commented Jun 16, 2019

@zero-24 Does it need another PR in the framework package for the 2.0-dev branch? No, clarified.

@Hackwar
Copy link
Member Author

Hackwar commented Jun 16, 2019

Since this is the wrong way to fix this, I'm closing this one.

@richard67
Copy link
Member

@Hackwar Please check PR #25243 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants