Fixing a mistake made with PR #24397 + fixing setting description for clarity

[AndySDH]

Pull Request for Issue #24754

Summary of Changes

PR #24397, introduced in Joomla 3.9.5, added a check to display the custom field on the frontend based on a parameter that was meant to be a check for the edit form, and not for the frontend display.

The author of that PR said that to un-do it I should create another PR myself so here it is.

As explained in this comment #24754 (comment), there already is another setting that controls whether a custom field should be displayed in the frontend or not.

That "Show on" setting is under "Form Options", and was/has always been for controlling where the field can be edited, not displayed. It just had a bad label/description.

With this PR I also take care of improving the description and label of that setting so that it causes no confusion on what it's actually doing and supposed to do.

Testing Instructions

• Create a Custom Field
• Set the "Editable In" (or without this PR: "Show on") parameter to "Administrator"
• Assign a value to it in an article

Current 3.9.6 result

• The field is not displayed on the frontend article either

Expected result with this PR

• The field should be displayed on the frontend article, but not on the frontend editing form.

Documentation Changes Required

Yes.
The label and description of the setting should be changed accordingly also here:
https://docs.joomla.org/J3.x:Adding_custom_fields/Parameters_for_all_Custom_Fields

[richard67]

@joomlahenk Please test

[richard67]

I have tested this item ✅ successfully on 7e7571c

I've tested it with an extended test compared to the testing instructions in the description:

• Created 2 fields, one with "Can be edited in" (or "Showon" without this PR) set to "Administrator" and the other set to "Site".
• Checked that when editing the article with both fields having assigned a value, the 1st field is editable in tab "Fields" in the artricle edit view in the backend and the 2nd field is not, and for frontend editing it is vice versa.

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25062.}

[richard67]

I have tested this item ✅ successfully on a4947b4

I've tested it with an extended test compared to the testing instructions in the description:

• Created 2 fields, one with "Can be edited in" (or "Showon" without this PR) set to "Administrator" and the other set to "Site".
• Checked that when editing the article with both fields having assigned a value, the 1st field is editable in tab "Fields" in the artricle edit view in the backend and the 2nd field is not, and for frontend editing it is vice versa.

  ---

  _{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25062.}

[Quy]

I have tested this item ✅ successfully on a4947b4

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25062.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25062.}

[AndySDH]

By the way, I noticed that the documentation here https://docs.joomla.org/J3.x:Adding_custom_fields/Parameters_for_all_Custom_Fields is outdated beyond this PR.
Joomla 3.9 changed the way Custom Field options are arranged and it was not reflected in the documentation there

[Quy]

I have tested this item ✅ successfully on 6e5a160

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25062.}

[HLeithner]

@brianteeman would you like to check the language strings before I merge this PR?

[HLeithner]

thx