Correct username in plg_actionlog

[tecpromotion]

Summary of Changes

In the User Actions Log extension, the user is always used in the output. The exception is the log entries related to the cache. Here, the user name is always used instead of the user.

With the change now value username is used instead of value name.

Testing Instructions

Create a new user with
name = Super User
and
username = test

Expected result

User test deleted cache group all

Actual result

User Super User deleted cache group all

Documentation Changes Required

--

[brianteeman]

Also see #24862

[degobbis]

I have tested this item ✅ successfully on c3f1500

thx

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24992.}

[alikon]

I have tested this item ✅ successfully on c3f1500

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24992.}

[zero-24]

Merging thanks.

[infograf768]

The filter by user is still using name and not username
This PR implies changes to the logcreator field.

Without a modification here I get

Issue solved if modifying the query to use username and not name

// Construct the query
			$query = $db->getQuery(true)
				->select($db->quoteName('u.id', 'value'))
				->select($db->quoteName('u.username', 'text'))
				->from($db->quoteName('#__users', 'u'))
				->join('INNER', $db->quoteName('#__action_logs', 'c') . ' ON ' . $db->quoteName('c.user_id') . ' = ' . $db->quoteName('u.id'))
				->group($db->quoteName('u.id'))
				->group($db->quoteName('u.username'))
				->order($db->quoteName('u.username'));

[zero-24]

@infograf768 can you send the required changes as PR?

[infograf768]

TBH, I am not sure about the whole thing
Yes, what is logged should be consistent BUT imho it should be the name and not the username displayed in the logs.
The reason is that the username is also the Login Name and this could be a security breach.
What do you think?

[infograf768]

This means that we have to do the reverse of that PR, i.e. use ->name everywhere and keep the filter as is.

[degobbis]

I do not see a security breach here. If you can see the action logs, then you can also access the users component and see the usernames. The improvement is that the username is unique and therefore faster to allocate.

[infograf768]

You are right that the name is not unique indeed (which is weird btw...).

Note: it is always the Name which is displayed in the Managers and Created by field (and its modal), which imho demonstrates that we should make the Name unique too...

[degobbis]

I don't think the name should be unique.
For a clear identification we already have 2 values, username and e-mail address. That's enough, or not?

But if it causes such far-reaching changes, is it perhaps sufficient to write the username in parentheses after the names in the output?
What do you all mean?

[infograf768]

Please test
#25291

Going further would need more important changes and should imho be reserved to J4.

[infograf768]

BTW, why keep using ->name in onUserAfterRemind($user)
It is not consistent imho.

[HLeithner]

username is unique, the name isn't. so imo it's better to use username

[brianteeman]

we must not make "name" unique. That would be terribly restrictive. Even with my almost unique family name there are two "brian teeman"

[HLeithner]

thats the reason that we stay with username instead using name.

[infograf768]

Understood that. Tks.