Skip to content

[4.0] com_menus sidebar#24866

Merged
wilsonge merged 5 commits intojoomla:4.0-devfrom
brianteeman:sidebar1
Jun 23, 2019
Merged

[4.0] com_menus sidebar#24866
wilsonge merged 5 commits intojoomla:4.0-devfrom
brianteeman:sidebar1

Conversation

@brianteeman
Copy link
Contributor

Removes the unused sidebar code from com_menus

Removes the unused sidebar code from com_menus
@brianteeman
Copy link
Contributor Author

Updated branch to retrigger drone time out errors unrelated to the code in this pr

@Quy
Copy link
Contributor

Quy commented May 13, 2019

Delete:

/**
* The sidebar markup
*
* @var string
* @since 4.0.0
*/
protected $sidebar;

@Quy
Copy link
Contributor

Quy commented May 13, 2019

I have tested this item ✅ successfully on 11a445f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24866.

@travisrisner
Copy link
Contributor

I have tested this item ✅ successfully on 11a445f

@Quy
Copy link
Contributor

Quy commented Jun 17, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24866.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 17, 2019
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge merged commit db99602 into joomla:4.0-dev Jun 23, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 23, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jun 23, 2019
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the sidebar1 branch June 23, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants