[4.0] Media grid size buttons #24770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The increase/decrease grid size buttons in the media manager have aria-hidden=true This change was made in joomla#23950 at the request of @zwiastunsw joomla#23950 (comment) I dont understand why that request was made but at a minimum its implementation is wrong A focusable element with aria-hidden="true" is ignored as part of the reading order, but still part of the focus order, making it’s state of visible or hidden unclear.
joomla-cms-bot
added
NPM Resource Changed
ghost
changed the title
Contributor
|
Not seeing any comment from @zwiastunsw so merging |
Contributor
Author
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The increase/decrease grid size buttons in the media manager have aria-hidden=true
This change was made in #23950 at the request of @zwiastunsw #23950 (comment)
I dont understand why that request was made but at a minimum its implementation is wrong
A focusable element with aria-hidden="true" is ignored as part of the reading order, but still part of the focus order, making it’s state of visible or hidden unclear. ie you can focus on the button but dont get told anything about the button