Skip to content

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Apr 15, 2019

Pull Request for Issue #23188.

Summary of Changes

respect docs & logic
https://docs.joomla.org/Tables/template_styles

@alikon alikon changed the title [SQL ] fix field home of #__template_styles table [SQL] fix field home of #__template_styles table Apr 15, 2019
@ghost
Copy link

ghost commented Apr 15, 2019

@GarryMoveOut please test.

@Quy
Copy link
Contributor

Quy commented Apr 17, 2019

Maybe the following is an issue when using PatchTester.

Run the Database fix the first time:

    Database schema version (3.9.3-2019-02-07) does not match CMS version (3.9.6-2019-04-15).
    Table 'nu7mb_template_styles' should not have index 'idx_home'. (From file 3.9.6-2019-04-15.sql.)
    Table 'nu7mb_template_styles' has the wrong type or attributes for column 'home' with type tinyint(1) unsigned. (From file 3.9.6-2019-04-15.sql.)

Then the result, but idx_home is not created.

Table 'nu7mb_template_styles' does not have index 'idx_home'. (From file 3.9.6-2019-04-15.sql.)

Run the Database fix again, then idx_home is created, however, this message remains:

Table 'nu7mb_template_styles' does not have index 'idx_home'. (From file 3.9.6-2019-04-15.sql.)

@alikon
Copy link
Contributor Author

alikon commented Apr 17, 2019

ummm maybe splitting the last "CREATE INDEX" in a new file .... i'll give it a try

@twister65
Copy link
Contributor

I have tested this item ✅ successfully on 2572ae5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24595.

@ghost
Copy link

ghost commented Apr 24, 2019

@GarryMoveOut please test > https://docs.joomla.org/Testing_Joomla!_patches

@GarryMoveOut
Copy link

Sorry for not responding for long time. I didn't have time. I will test soon, maybe this in week.

@Quy
Copy link
Contributor

Quy commented Jun 15, 2019

I have tested this item ✅ successfully on 1116780


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24595.

@Quy
Copy link
Contributor

Quy commented Jun 15, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24595.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 15, 2019
@HLeithner HLeithner merged commit 554d53d into joomla:staging Jun 16, 2019
@HLeithner
Copy link
Member

thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 16, 2019
@HLeithner HLeithner added this to the Joomla 3.9.9 milestone Jun 16, 2019
@alikon alikon deleted the patch-113 branch June 18, 2019 14:32
@richard67
Copy link
Member

This PR had errors which are fixed now in PR #25299 . Please test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants