Skip to content

[3.9][JLayout images] Remove unnecessary isset(...)#24390

Merged
HLeithner merged 4 commits intojoomla:stagingfrom
ReLater:patch-7
Mar 28, 2019
Merged

[3.9][JLayout images] Remove unnecessary isset(...)#24390
HLeithner merged 4 commits intojoomla:stagingfrom
ReLater:patch-7

Conversation

@ReLater
Copy link
Contributor

@ReLater ReLater commented Mar 27, 2019

Testing Instructions

  • Code review. We don't need the additional isset(...) check because !empty(...) is sufficient.

Expected result

  • No changes with output of intro images in category blogs and featured blogs
  • No changes with output of full images in article views

Actual result

  • Unnecessary code.

@ReLater ReLater changed the title [3.9][JLayout inro_image] Remove unnecessary isset(...) [3.9][JLayout images] Remove unnecessary isset(...) Mar 27, 2019
@Quy
Copy link
Contributor

Quy commented Mar 28, 2019

I have tested this item ✅ successfully on 7d9faeb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24390.

1 similar comment
@SharkyKZ
Copy link
Contributor

I have tested this item ✅ successfully on 7d9faeb


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24390.

@ghost
Copy link

ghost commented Mar 28, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 28, 2019
@HLeithner HLeithner merged commit f1d2095 into joomla:staging Mar 28, 2019
@HLeithner
Copy link
Member

thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 28, 2019
@HLeithner HLeithner added this to the Joomla 3.9.5 milestone Mar 28, 2019
@ReLater ReLater deleted the patch-7 branch March 28, 2019 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants