Skip to content

[3.9][com_content featured] Remove redundant intro_image check#24389

Merged
HLeithner merged 2 commits intojoomla:stagingfrom
ReLater:patch-1
Mar 29, 2019
Merged

[3.9][com_content featured] Remove redundant intro_image check#24389
HLeithner merged 2 commits intojoomla:stagingfrom
ReLater:patch-1

Conversation

@ReLater
Copy link
Contributor

@ReLater ReLater commented Mar 27, 2019

Summary of Changes

  • Remove lines for check if intro image exists because this is done in JLayout already.

Testing Instructions

Code review in pr plus code of JLayout joomla.content.intro_image https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/content/intro_image.php#L14

Or:

  • Create some featured articles with and without intro images.
  • Test that nothing has changed after applying the patch. Intro images are displayed or not.

Expected result

  • Nothing has changed.

Actual result

  • Unnecessary/redundant code.

@ReLater ReLater changed the title [3.9][com_content features] Remove redundant intro_image check [3.9][com_content featured] Remove redundant intro_image check Mar 27, 2019
@SharkyKZ
Copy link
Contributor

I have tested this item ✅ successfully on 6a91da1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24389.

@Quy
Copy link
Contributor

Quy commented Mar 28, 2019

I have tested this item ✅ successfully on 0e99716


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24389.

@Quy
Copy link
Contributor

Quy commented Mar 28, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24389.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 28, 2019
@HLeithner HLeithner merged commit 19f0d85 into joomla:staging Mar 29, 2019
@HLeithner
Copy link
Member

thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 29, 2019
@HLeithner HLeithner added this to the Joomla 3.9.5 milestone Mar 29, 2019
@ReLater ReLater deleted the patch-1 branch March 29, 2019 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants