Skip to content

Fallback com_users new_usertype to guest_usergroup or public and not hardcode group id's#24363

Merged
HLeithner merged 3 commits intojoomla:stagingfrom
zero-24:hardcoded_usergroup_ids
Apr 2, 2019
Merged

Fallback com_users new_usertype to guest_usergroup or public and not hardcode group id's#24363
HLeithner merged 3 commits intojoomla:stagingfrom
zero-24:hardcoded_usergroup_ids

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Mar 26, 2019

Pull Request for an issue raised by @bembelimen

Summary of Changes

Make sure the new_usertype is not hardcoded and in case it does not exists falls back to the guest_usergroup or the static id 1 / public.

Testing Instructions

Clear the default value for new_usertype and check that guest_usergroup or 1 is used.

Expected result

guest_usergroup or 1 is used when new_usertype is not configured

Actual result

fallback is hardcoded

Documentation Changes Required

none

cc @bembelimen @SniperSister @HLeithner

@zero-24 zero-24 added this to the Joomla 3.9.5 milestone Mar 26, 2019
@Quy
Copy link
Contributor

Quy commented Apr 1, 2019

I have tested this item ✅ successfully on 3800d0b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24363.

@HLeithner
Copy link
Member

We need second test here.

@alikon
Copy link
Contributor

alikon commented Apr 2, 2019

I have tested this item ✅ successfully on 3800d0b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24363.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.9.5 milestone Apr 2, 2019
@ghost
Copy link

ghost commented Apr 2, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 2, 2019
@HLeithner HLeithner merged commit 3b14a62 into joomla:staging Apr 2, 2019
@HLeithner
Copy link
Member

thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 2, 2019
@HLeithner HLeithner added this to the Joomla 3.9.5 milestone Apr 2, 2019
@zero-24 zero-24 deleted the hardcoded_usergroup_ids branch April 2, 2019 14:47
@zero-24
Copy link
Contributor Author

zero-24 commented Apr 2, 2019

Thanks. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants