Fallback com_users new_usertype to guest_usergroup or public and not hardcode group id's#24363
Merged
HLeithner merged 3 commits intojoomla:stagingfrom Apr 2, 2019
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on 3800d0b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24363. |
Member
|
We need second test here. |
Contributor
|
I have tested this item ✅ successfully on 3800d0b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24363. |
|
Status "Ready To Commit". |
Member
|
thx |
Contributor
Author
|
Thanks. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for an issue raised by @bembelimen
Summary of Changes
Make sure the new_usertype is not hardcoded and in case it does not exists falls back to the guest_usergroup or the static id 1 / public.
Testing Instructions
Clear the default value for new_usertype and check that guest_usergroup or 1 is used.
Expected result
guest_usergroup or 1 is used when new_usertype is not configured
Actual result
fallback is hardcoded
Documentation Changes Required
none
cc @bembelimen @SniperSister @HLeithner