Skip to content

[4.0] [a11y] Remove redundant title from layouts and plugins #24280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wilsonge merged 3 commits into from
Mar 21, 2019
Merged

[4.0] [a11y] Remove redundant title from layouts and plugins #24280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa0a411
[4.0] [a11y] Remove redundant title from layouts and plugins
brianteeman Mar 21, 2019
5e415ea
Update layouts/joomla/searchtools/default/bar.php
SharkyKZ Mar 21, 2019
e31305c
Update layouts/joomla/searchtools/default/bar.php
SharkyKZ Mar 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion administrator/components/com_media/layouts/toolbar/create-folder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@
$title = Text::_('COM_MEDIA_CREATE_NEW_FOLDER');
?>
<button class="btn btn-sm btn-info" onclick="MediaManager.Event.fire('onClickCreateFolder');">
<span class="icon-folder-close" title="<?php echo $title; ?>"></span> <?php echo $title; ?>
<span class="icon-folder-close"></span> <?php echo $title; ?>
</button>
2 changes: 1 addition & 1 deletion administrator/components/com_media/layouts/toolbar/delete.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@
$title = Text::_('JTOOLBAR_DELETE');
?>
<button id="mediaDelete" class="btn btn-sm btn-danger" onclick="MediaManager.Event.fire('onClickDelete');">
<span class="icon-delete" title="<?php echo $title; ?>"></span> <?php echo $title; ?>
<span class="icon-delete"></span> <?php echo $title; ?>
</button>
2 changes: 1 addition & 1 deletion administrator/components/com_media/layouts/toolbar/upload.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@
$title = Text::_('JTOOLBAR_UPLOAD');
?>
<button class="btn btn-sm btn-success" onclick="MediaManager.Event.fire('onClickUpload');">
<span class="icon-upload" title="<?php echo $title; ?>"></span> <?php echo $title; ?>
<span class="icon-upload"></span> <?php echo $title; ?>
</button>
2 changes: 1 addition & 1 deletion administrator/components/com_modules/layouts/toolbar/cancelselect.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,6 @@

$text = Text::_('JTOOLBAR_CANCEL');
?>
<button onclick="location.href='index.php?option=com_modules'" class="btn btn-sm btn-danger" title="<?php echo $text; ?>">
<button onclick="location.href='index.php?option=com_modules'" class="btn btn-sm btn-danger">
<span class="icon-cancel" aria-hidden="true"></span> <?php echo $text; ?>
</button>
2 changes: 1 addition & 1 deletion layouts/joomla/form/field/contenthistory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
);

?>
<button type="button" onclick="document.getElementById('versionsModal').open()" class="btn btn-secondary" data-toggle="modal" title="<?php echo $label; ?>">
<button type="button" onclick="document.getElementById('versionsModal').open()" class="btn btn-secondary" data-toggle="modal">
<span class="fa fa-code-fork" aria-hidden="true"></span>
<?php echo $label; ?>
</button>
3 changes: 1 addition & 2 deletions layouts/joomla/pagination/link.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@
}

$class = 'active';
$title = 'title="' . $item->text . '"';
$onClick = 'document.adminForm.' . $item->prefix . 'limitstart.value=' . ($item->base > 0 ? $item->base : '0') . '; Joomla.submitform();return false;';
}
else
Expand All @@ -74,7 +73,7 @@
?>
<?php if ($displayData['active']) : ?>
<li class="<?php echo $class; ?> page-link">
<a <?php echo $title; ?> aria-label="<?php echo $aria; ?>" href="#" onclick="<?php echo $onClick; ?>">
<a aria-label="<?php echo $aria; ?>" href="#" onclick="<?php echo $onClick; ?>">
<?php echo $display; ?>
</a>
</li>
Expand Down
5 changes: 2 additions & 3 deletions layouts/joomla/searchtools/default/bar.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@

defined('JPATH_BASE') or die;

use Joomla\CMS\HTML\HTMLHelper;
use Joomla\CMS\Language\Text;
use Joomla\Registry\Registry;

Expand Down Expand Up @@ -44,13 +43,13 @@
</label>
<?php echo $filters['filter_search']->input; ?>
<span class="input-group-append">
<button type="submit" class="btn btn-primary hasTooltip" title="<?php echo HTMLHelper::_('tooltipText', 'JSEARCH_FILTER_SUBMIT'); ?>" aria-label="<?php echo Text::_('JSEARCH_FILTER_SUBMIT'); ?>">
<button type="submit" class="btn btn-primary" aria-label="<?php echo Text::_('JSEARCH_FILTER_SUBMIT'); ?>">
<span class="fa fa-search" aria-hidden="true"></span>
</button>
</span>
</div>
</div>
<button type="button" class="btn btn-primary hasTooltip js-stools-btn-clear mr-2" title="<?php echo HTMLHelper::_('tooltipText', 'JSEARCH_FILTER_CLEAR'); ?>">
<button type="button" class="btn btn-primary js-stools-btn-clear mr-2">
<?php echo Text::_('JSEARCH_FILTER_CLEAR'); ?>
</button>
<div class="btn-group">
Expand Down
1 change: 0 additions & 1 deletion layouts/joomla/tinymce/togglebutton.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
<div class="btn-group">
<button type="button" class="btn btn-secondary" href="#"
onclick="tinyMCE.execCommand('mceToggleEditor', false, '<?php echo $name; ?>');return false;"
title="<?php echo Text::_('PLG_TINY_BUTTON_TOGGLE_EDITOR'); ?>"
>
<span class="icon-eye" aria-hidden="true"></span>
<?php echo Text::_('PLG_TINY_BUTTON_TOGGLE_EDITOR'); ?>
Expand Down
2 changes: 1 addition & 1 deletion layouts/joomla/toolbar/modal.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
]
);
?>
<button<?php echo $id; ?> onclick="document.getElementById('modal_<?php echo $selector; ?>').open()" class="<?php echo $class; ?>" data-toggle="modal" title="<?php echo $text; ?>">
<button<?php echo $id; ?> onclick="document.getElementById('modal_<?php echo $selector; ?>').open()" class="<?php echo $class; ?>" data-toggle="modal">
<span class="<?php echo $icon; ?>" aria-hidden="true"></span>
<?php echo $text; ?>
</button>
3 changes: 1 addition & 2 deletions layouts/joomla/toolbar/versions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@
<button<?php echo $id ?? ''; ?>
onclick="document.getElementById('versionsModal').open()"
class="btn btn-primary"
data-toggle="modal"
title="<?php echo $title; ?>">
data-toggle="modal">
<span class="fa fa-code-fork" aria-hidden="true"></span><?php echo $title; ?>
</button>
1 change: 0 additions & 1 deletion plugins/user/profile/field/tos.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ protected function getLabel()
// If a description is specified, use it to build a tooltip.
if (!empty($this->description))
{
$label .= ' title="' . htmlspecialchars(trim($text, ':'), ENT_COMPAT, 'UTF-8') . '"';
$label .= ' data-content="' . htmlspecialchars(
$this->translateDescription ? Text::_($this->description) : $this->description,
ENT_COMPAT,
Expand Down