Conversation
|
Thank you for such a speedy response. I will test his in the morning |
|
I have tested this item ✅ successfully on 550ddf2 I could not test if QR code is scannable and/or correct. Decide yourself if that's a successful test! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24255. |
Co-Authored-By: bembelimen <bembelimen@users.noreply.github.com>
|
|
||
| HTMLHelper::_('script', 'plg_twofactorauth_totp/qrcode.min.js', array('version' => 'auto', 'relative' => true)); | ||
|
|
||
| $js = " |
There was a problem hiding this comment.
Can you not put this in a separate file in the media directory so it doesn't need to be done for J4?
There was a problem hiding this comment.
Joomla 4 should get a webcomponent for displaying qrcodes.
There was a problem hiding this comment.
Even if that's the case, any new additional JS for J3 should be whacked in a separate file so that it makes the migration a lot easier
There was a problem hiding this comment.
Github fools me... you mean the inline js should be moved. ok that makes sense
There was a problem hiding this comment.
sorry, I probably should be moved my comment down a couple more lines :)
|
For my own reference when it comes to J4 the library is https://github.com/kazuhikoarase/qrcode-generator/blob/master/js/package.json#L2 |
|
thx |
|
I installed 3.9.5 but the fix for the QR-Code for 2FA still does not work on my Joomla installation. Do I have do to something special to get it working again? |
|
@deroderuiter strange I tested it again and it works for me, do you have a screenshot and could you create a new issue. |
|
There is not much to show. In edit profile I choose the tab Two Factor Authentication, I scan the QR code with the Google Authenticator App on my smartphone and fill in the code and save the page. No error is displayed but the tow factor authentication is not activated. |
|
I saw I remark of Phil Taylor that Google no longer provides a chart API for QR Code. It was actually deprecated in 2012 and turned off Completely on March 18,2019 |
|
if you see the qr code then the issue you refer to above is resolved as the qr code has been generated by different code |
|
So probably I have an other problem? |
10 participants
Pull Request for Issue #24252 .
Summary of Changes
Implements an internal QR-Code generator instead of the google charts.
Testing Instructions
Activate the Google Authenticator 2FA plugin and set up 2FA for one user.
Expected result
QR-Code visible
Actual result
QR-Code broken