Skip to content

[4.0] Label com_content#24242

Merged
wilsonge merged 3 commits intojoomla:4.0-devfrom
hardik-codes:label-com_content
Mar 21, 2019
Merged

[4.0] Label com_content#24242
wilsonge merged 3 commits intojoomla:4.0-devfrom
hardik-codes:label-com_content

Conversation

@hardik-codes
Copy link
Contributor

This PR adds a label in the tab where only editor is present in com_content.

Testing Instructions

Open any article in articles overview

Expected result

A label is there in a tab where only editor is present.
Like in the case of com_category
com_categories

In case of com_contact
com_contact(3)

Actual result

No label is there

Documentation Changes Required

None

@brianteeman
Copy link
Contributor

This is not correct - see #23946

@hardik-codes
Copy link
Contributor Author

hardik-codes commented Mar 19, 2019

@brianteeman IMO this PR more or less does the same thing as #23946

@brianteeman
Copy link
Contributor

brianteeman commented Mar 19, 2019

It does the opposite

@hardik-codes
Copy link
Contributor Author

It does the opposite

Could you please elaborate with the help of code

@brianteeman
Copy link
Contributor

brianteeman commented Mar 19, 2019

the code is there for you to read in the pr

@brianteeman
Copy link
Contributor

Sorry i was not thinking - just ignore me

@hardik-codes
Copy link
Contributor Author

No issues

Co-Authored-By: hardik-codes <hardik06agarwal@gmail.com>
@hardik-codes
Copy link
Contributor Author

@Quy I wanted to know why does this happen because the indentation seems to be fine in my text editor but after having pushed the code to github, the indentation is disturbed

@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge merged commit 20c1c8a into joomla:4.0-dev Mar 21, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Mar 21, 2019
@hardik-codes hardik-codes deleted the label-com_content branch April 18, 2019 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants