Add minimum lowercase rule for password validation. by HLeithner · Pull Request #24230 · joomla/joomla-cms

HLeithner · 2019-03-18T13:04:27Z

Pull Request for Issue #24156 .

Summary of Changes

Add missing lower case requirement for passwords

Testing Instructions

Set minimum lowercase count to 0 or higher.
Change password. Use password with more and less lowercase characters

Expected result

It should be possible to force a minimum of lowercase characters.

Actual result

Option is missing.

brianteeman · 2019-03-18T14:07:37Z

administrator/language/en-GB/en-GB.com_admin.ini

 ; Messages
 COM_USERS_MSG_NOT_ENOUGH_INTEGERS_N="Password does not have enough digits. At least %s digits are required."
 COM_USERS_MSG_NOT_ENOUGH_INTEGERS_N_1="Password does not have enough digits. At least 1 digit is required."
+COM_USERS_MSG_NOT_ENOUGH_LOWERCASE_LETTERS_N="Password does not have enough lowercase characters. At least %s lower case characters are required."


Lower case can be written as either one word or two. At a minimum we should be consistent in only using one variant. Using the gov.uk website as a source we should standardise on one word not two

brianteeman · 2019-03-18T14:07:48Z

administrator/language/en-GB/en-GB.com_admin.ini

 COM_USERS_MSG_NOT_ENOUGH_INTEGERS_N="Password does not have enough digits. At least %s digits are required."
 COM_USERS_MSG_NOT_ENOUGH_INTEGERS_N_1="Password does not have enough digits. At least 1 digit is required."
+COM_USERS_MSG_NOT_ENOUGH_LOWERCASE_LETTERS_N="Password does not have enough lowercase characters. At least %s lower case characters are required."
+COM_USERS_MSG_NOT_ENOUGH_LOWERCASE_LETTERS_N_1="Password does not have enough lowercase characters. At least 1 lower case character is required."


HLeithner · 2019-03-18T14:27:24Z

I did a copy of the uppercase sentence,.. should be changed too?

brianteeman · 2019-03-18T14:30:02Z

I just realised that too ;)

I don't care if we use one word or two but we should be consistent - especially in the same sentence. Should help the translators as well

Quy · 2019-03-18T15:07:20Z

administrator/language/en-GB/en-GB.com_users.ini

 COM_USERS_CONFIG_FIELD_MINIMUM_INTEGERS="Minimum Integers"
 COM_USERS_CONFIG_FIELD_MINIMUM_INTEGERS_DESC="Set the minimum number of integers that must be included in a password."
+COM_USERS_CONFIG_FIELD_MINIMUM_LOWERCASE="Minimum Lower Case"
+COM_USERS_CONFIG_FIELD_MINIMUM_LOWERCASE_DESC="Set the minimum number of lower case alphabetical characters required for a password."


Change here? Label too?

eric-lamy-agerix · 2019-03-18T15:14:37Z

Tested with Joomla! Patch Tester and it works fine

ghost · 2019-03-18T15:17:41Z

@agerix please mark your Test at Issue Tracker as "Tested successfully".

eric-lamy-agerix · 2019-03-18T15:22:46Z

I have tested this item ✅ successfully on ee1d90a

Hello, I've test with one and with more than one lower case

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24230.}

eric-lamy-agerix · 2019-03-18T15:23:46Z

I've just do it Franz, I'm a new tester... :)

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24230.}

HLeithner · 2019-03-18T15:24:08Z

@Quy you are right, I changed all to two words as in the label.

dgrammatiko · 2019-03-18T15:34:25Z

@HLeithner you need to reflect these changes here: https://github.com/joomla/joomla-cms/blob/staging/media/system/js/passwordstrength.js

A fair warning tho, that file is Mootools based so in essence wouldn't be advisable to ask anyone to add any new functionality there. In short better do this in the 4.0 repo...

brianteeman · 2019-03-18T15:36:49Z

This is already available in j4

dgrammatiko · 2019-03-18T15:39:18Z

This is already available in j4

Well I lost track of the things I did already for J4 😉

Anyways, then at a bare minimum, the last function in the Mootools version needs to be adapted

HLeithner · 2019-03-18T15:39:54Z

@dgrammatiko this file looks like its only show the password strength and doesn't have anything to do with the requirement.

dgrammatiko · 2019-03-18T15:40:53Z

@HLeithner it should read the requirements for calculating the strength, or maybe not...

HLeithner · 2019-03-18T15:45:06Z

The script uses the threshold that is set as parameter I didn't find any calculation based on the requirements parameters...

Quy · 2019-03-20T23:28:46Z

I have tested this item ✅ successfully on da122f3

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24230.}

jeckodevelopment · 2019-03-21T07:44:41Z

@agerix can you please submit again your test?

alikon · 2019-03-21T07:50:29Z

libraries/src/Form/Rule/PasswordRule.php

+
+			if ($nLowercase < $minimumLowercase)
+			{
+				\JFactory::getApplication()->enqueueMessage(


should be easy to namespace

alikon · 2019-03-21T07:50:47Z

libraries/src/Form/Rule/PasswordRule.php

+			if ($nLowercase < $minimumLowercase)
+			{
+				\JFactory::getApplication()->enqueueMessage(
+					\JText::plural('COM_USERS_MSG_NOT_ENOUGH_LOWERCASE_LETTERS_N', $minimumLowercase),


HLeithner · 2019-03-21T09:37:08Z

If I add the name spaces here I have to change the complete file and I think this would maybe give a merge conflict when george merge it into 4.0

brianteeman · 2019-03-21T09:39:47Z

J4 already has a lowercase rule

alikon · 2019-03-21T11:44:10Z

maybe it's me but the 4.0 https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Form/Rule/PasswordRule.php didn't have lowercase yet....

@HLeithner not an expert on "easy merging" matter but looking the 2 file side by side ....

alikon · 2019-03-21T18:03:14Z

I have tested this item ✅ successfully on e386929

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24230.}

Quy · 2019-03-21T18:26:27Z

I have tested this item ✅ successfully on e386929

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24230.}

Quy · 2019-03-21T18:26:37Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24230.}

HLeithner added 2 commits March 18, 2019 13:58

Add minimum lowercase rule for password validation.

5523a23

Do actual lowercase testing...

df83f75

joomla-cms-bot added Language Change This is for Translators PR-staging labels Mar 18, 2019

brianteeman reviewed Mar 18, 2019

View reviewed changes

Use one word for lowercase and uppercase.

ee1d90a

Quy reviewed Mar 18, 2019

View reviewed changes

Use two words for lower case and upper case.

da122f3

Merge branch 'staging' into add-lowercase-password-check

e386929

alikon reviewed Mar 21, 2019

View reviewed changes

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 21, 2019

Merge branch 'staging' into add-lowercase-password-check

86b0867

wilsonge merged commit 857fa53 into joomla:staging Mar 22, 2019

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 22, 2019

zero-24 added this to the Joomla 3.9.5 milestone Mar 22, 2019

zero-24 mentioned this pull request Mar 22, 2019

[3.9.5] Add new strings and use outwritten numbers joomlagerman/joomla#696

Merged

HLeithner deleted the add-lowercase-password-check branch March 29, 2020 19:15

Uh oh!

Conversation

HLeithner commented Mar 18, 2019

Summary of Changes

Testing Instructions

Expected result

Actual result

Uh oh!

brianteeman Mar 18, 2019

Choose a reason for hiding this comment

Uh oh!

brianteeman Mar 18, 2019

Choose a reason for hiding this comment

Uh oh!

HLeithner commented Mar 18, 2019

Uh oh!

brianteeman commented Mar 18, 2019

Uh oh!

Quy Mar 18, 2019

Choose a reason for hiding this comment

Uh oh!

eric-lamy-agerix commented Mar 18, 2019

Uh oh!

ghost commented Mar 18, 2019

Uh oh!

eric-lamy-agerix commented Mar 18, 2019

Uh oh!

eric-lamy-agerix commented Mar 18, 2019

Uh oh!

HLeithner commented Mar 18, 2019

Uh oh!

dgrammatiko commented Mar 18, 2019

Uh oh!

brianteeman commented Mar 18, 2019

Uh oh!

dgrammatiko commented Mar 18, 2019

Uh oh!

HLeithner commented Mar 18, 2019

Uh oh!

dgrammatiko commented Mar 18, 2019

Uh oh!

HLeithner commented Mar 18, 2019

Uh oh!

Quy commented Mar 20, 2019

Uh oh!

jeckodevelopment commented Mar 21, 2019

Uh oh!

alikon Mar 21, 2019

Choose a reason for hiding this comment

Uh oh!

alikon Mar 21, 2019

Choose a reason for hiding this comment

Uh oh!

HLeithner commented Mar 21, 2019

Uh oh!

brianteeman commented Mar 21, 2019

Uh oh!

alikon commented Mar 21, 2019

Uh oh!

alikon commented Mar 21, 2019

Uh oh!

Quy commented Mar 21, 2019

Uh oh!

Quy commented Mar 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants