Skip to content

[plg_content_pagenavigation] Missing Bootstrap tooltip import#24203

Merged
HLeithner merged 3 commits intojoomla:stagingfrom
SharkyKZ:plgContentPagenavigation
Apr 2, 2019
Merged

[plg_content_pagenavigation] Missing Bootstrap tooltip import#24203
HLeithner merged 3 commits intojoomla:stagingfrom
SharkyKZ:plgContentPagenavigation

Conversation

@SharkyKZ
Copy link
Contributor

Pull Request for Issue #22256 .

Summary of Changes

Imports Bootstrap tooltips.

Testing Instructions

Enable Content - Page Navigation plugin. Open an article. Hover over the navigation links generated by the plugin.

Expected result

Article title shown in Bootstrap tooltips.

Actual result

Default browser tooltips.

Documentation Changes Required

No.

@ghost
Copy link

ghost commented Mar 16, 2019

@sandewt please test this Pull Request.

@Quy
Copy link
Contributor

Quy commented Mar 27, 2019

Without this PR, I see the Bootstrap tooltips.

@SharkyKZ
Copy link
Contributor Author

@Quy that's possible if something else loads tooltips. Login module, for example.

@Quy
Copy link
Contributor

Quy commented Mar 27, 2019

I have tested this item ✅ successfully on b2dc133


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24203.

@sandewt
Copy link
Contributor

sandewt commented Mar 28, 2019

I have tested this item ✅ successfully on b2dc133

PHP Version 7.1.20
Web Server Apache/2.4.34 (Win32) OpenSSL/1.0.2o PHP/7.1.20
WebServer to PHP Interface apache2handler
Joomla! Version Joomla! 3.9.5-dev Development [ Amani ] 12-March-2019 15:27 GMT


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24203.

@ghost
Copy link

ghost commented Mar 28, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 28, 2019
@HLeithner HLeithner merged commit c2b127d into joomla:staging Apr 2, 2019
@HLeithner HLeithner added this to the Joomla 3.9.5 milestone Apr 2, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 2, 2019
@HLeithner
Copy link
Member

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants