Skip to content

[3.9] Message reporting changed to error type#24200

Merged
zero-24 merged 3 commits intojoomla:stagingfrom
hardik-codes:Fix#24177
Mar 21, 2019
Merged

[3.9] Message reporting changed to error type#24200
zero-24 merged 3 commits intojoomla:stagingfrom
hardik-codes:Fix#24177

Conversation

@hardik-codes
Copy link
Contributor

@hardik-codes hardik-codes commented Mar 16, 2019

Pull Request for Issue #24177

Summary of Changes

Changed the message reporting at the time of log in to error type.

Expected result

The message should be of warning type

Actual result

The message is green, a positive and successful action.

Documentation Changes Required

None

@HLeithner
Copy link
Member

Isn't this an error?

@hardik-codes
Copy link
Contributor Author

Isn't this an error?

In the issue it was mentioned by @kofaysi to make it to warning type that's why I made it warning type

@HLeithner
Copy link
Member

please change it to error.

@hardik-codes
Copy link
Contributor Author

please change it to error.

Ok I'll do so

@hardik-codes
Copy link
Contributor Author

Now have a look @HLeithner

@HLeithner HLeithner changed the title [staging] Message reporting changed to warning type [3.9] Message reporting changed to warning type Mar 18, 2019
@HLeithner
Copy link
Member

thx, now we need 2 testers.

@Quy
Copy link
Contributor

Quy commented Mar 19, 2019

I have tested this item ✅ successfully on 35becdf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24200.

@hardik-codes hardik-codes changed the title [3.9] Message reporting changed to warning type [3.9] Message reporting changed to error type Mar 19, 2019
@ReLater
Copy link
Contributor

ReLater commented Mar 19, 2019

I have tested this item ✅ successfully on 35becdf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24200.

@ghost
Copy link

ghost commented Mar 19, 2019

Status "Ready To Commit".

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 19, 2019
@zero-24 zero-24 added this to the Joomla 3.9.5 milestone Mar 21, 2019
@zero-24
Copy link
Contributor

zero-24 commented Mar 21, 2019

Merging this into Joomla 3.9.5 now thanks @hardik-codes for your first contribution to Joomla. 🎉

@zero-24 zero-24 merged commit 7a77046 into joomla:staging Mar 21, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 21, 2019
@hardik-codes
Copy link
Contributor Author

Merging this into Joomla 3.9.5 now thanks @hardik-codes for your first contribution to Joomla. tada

Thanks @zero-24, but I have contributed to Joomla before as well and will continue to do the same.

@zero-24
Copy link
Contributor

zero-24 commented Mar 22, 2019

Hmm GitHub fooled me than. It showed first contribution to me. But anyway thanks and good to hear 👍

@hardik-codes hardik-codes deleted the Fix#24177 branch April 18, 2019 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants