[3.9] Message reporting changed to error type#24200
Conversation
|
Isn't this an error? |
In the issue it was mentioned by @kofaysi to make it to warning type that's why I made it warning type |
|
please change it to error. |
Ok I'll do so |
|
Now have a look @HLeithner |
|
thx, now we need 2 testers. |
|
I have tested this item ✅ successfully on 35becdf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24200. |
|
I have tested this item ✅ successfully on 35becdf This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24200. |
|
Status "Ready To Commit". |
|
Merging this into Joomla 3.9.5 now thanks @hardik-codes for your first contribution to Joomla. 🎉 |
Thanks @zero-24, but I have contributed to Joomla before as well and will continue to do the same. |
|
Hmm GitHub fooled me than. It showed |
Pull Request for Issue #24177
Summary of Changes
Changed the message reporting at the time of log in to error type.
Expected result
The message should be of warning type
Actual result
The message is green, a positive and successful action.
Documentation Changes Required
None