[4.0] WebAssetManager: Speed up enable/disable asset#23713
Merged
wilsonge merged 9 commits intojoomla:4.0-devfrom May 5, 2019
Merged
[4.0] WebAssetManager: Speed up enable/disable asset#23713wilsonge merged 9 commits intojoomla:4.0-devfrom
wilsonge merged 9 commits intojoomla:4.0-devfrom
Conversation
Member
Author
|
I think I am banned to see ci.joomla.org, so cannot help with Drone, sorry 😄 |
Contributor
|
@Fedik here is the failure: |
Member
Author
|
@dgrammatiko thanks! |
dgrammatiko
suggested changes
Jan 29, 2019
Conflicts: libraries/src/WebAsset/WebAssetManager.php libraries/src/WebAsset/WebAssetManagerInterface.php
Conflicts: libraries/src/WebAsset/WebAssetManager.php libraries/src/WebAsset/WebAssetManagerInterface.php
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
WebAssetManager calculate dependencies on "request" (when it really need) instead of each call of
enableAsset/disableAsset.This will speed up operations like:
Additionally I have updated a comment for a Manager interface, added missed throws tags.
Testing Instructions
Apply the patch and make sure everything still work 😉
ping @wilsonge
for reference #22435