[4.0] WebAsset: split WebAssetRegistry to Registry and Manager#23463
Merged
wilsonge merged 17 commits intojoomla:4.0-devfrom Jan 8, 2019
Merged
[4.0] WebAsset: split WebAssetRegistry to Registry and Manager#23463wilsonge merged 17 commits intojoomla:4.0-devfrom
wilsonge merged 17 commits intojoomla:4.0-devfrom
Conversation
Contributor
|
This looks much better as an API :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
As discussed in #23415.
The patch splits
WebAssetRegistrytoWebAssetRegistryandWebAssetManager.Additionally it fixes FIFO order of enabled assets and fix #23415.
In general
In general now it like that:
In Joomla! context
In Joomla! context
WebAssetRegistryis a global service, andWebAssetManagerper document instance.Internaly
WebAssetRegistryload all known assets fromjoomla.asset.json.Work with WebAssetManager:
@mbabker @wilsonge please review
Documentation Changes Required
yeap
for reference #22435