[4.0] PR #21558 moved system-message outside if(empty) in layouts/joomla/system/message.php file

[conseilgouz]

Pull Request for Issue #23420 .

Summary of Changes

Moved <div id="system-messsage"> back inside <?php if....>

Testing Instructions

With your WebBrowser DevTools, check that <div id="system-message"><div> is not displayed if no system message is to be displayed

[bembelimen]

Did you check, if the JS errors (e.g. form submit in the frontend) still works? If I remember correctly, the JS messages will be injected into this div...

[conseilgouz]

@bembelimen : I just put back the div where it was before pr #21558.

There is no need to display this div if no message has to be displayed. If you have an error message or a notice, it will be.

[Quy]

JS messages are injected in Media Manager so this will PR will not work.
To test, upload or delete a file. No alert shown.

const messageContainer = document.getElementById('system-message');

[joomla-cms-bot]

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/23421

[brianteeman]

Please always give a reason when you close something

[Quy]

I did. See my previous reply.