Skip to content

[4.0] Fix "Too few arguments to function onContentBeforeSave"#23395

Closed
ReLater wants to merge 1 commit intojoomla:4.0-devfrom
ReLater:patch-2
Closed

[4.0] Fix "Too few arguments to function onContentBeforeSave"#23395
ReLater wants to merge 1 commit intojoomla:4.0-devfrom
ReLater:patch-2

Conversation

@ReLater
Copy link
Contributor

@ReLater ReLater commented Dec 30, 2018

Pull Request for Issue #23276 , #23401

Testing Instructions

  • Create a new administrator menu:
    Too few arguments to function PlgContentJoomla::onContentBeforeSave(), 3 passed in D:\www\joomla4\libraries\src\Plugin\CMSPlugin.php on line 287 and exactly 4 expected
  • Apply patch.
  • Create a new administrator menu without error.

@chmst
Copy link
Contributor

chmst commented Dec 30, 2018

I have tested this item ✅ successfully on 5e3eb83

Tested successfully when storing a new tag. See: Issue #23401.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23395.

@ChristineWk
Copy link

I have tested this item ✅ successfully on 5e3eb83


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23395.

@Quy
Copy link
Contributor

Quy commented Dec 30, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23395.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed PR-4.0-dev labels Dec 30, 2018
@ReLater
Copy link
Contributor Author

ReLater commented Jan 13, 2019

This solution is wrong for J4 where $data is a required argument now that has to be provided by the component.

For com_tags test #23531 please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants