[4.0] Fix "Too few arguments to function onContentBeforeSave"#23395
Closed
ReLater wants to merge 1 commit intojoomla:4.0-devfrom
ReLater:patch-2
Closed
[4.0] Fix "Too few arguments to function onContentBeforeSave"#23395ReLater wants to merge 1 commit intojoomla:4.0-devfrom ReLater:patch-2
ReLater wants to merge 1 commit intojoomla:4.0-devfrom
ReLater:patch-2
Conversation
This was referenced Dec 30, 2018
Contributor
|
I have tested this item ✅ successfully on 5e3eb83 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23395. |
|
I have tested this item ✅ successfully on 5e3eb83 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23395. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23395. |
Contributor
Author
|
This solution is wrong for J4 where $data is a required argument now that has to be provided by the component. For com_tags test #23531 please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #23276 , #23401
Testing Instructions
Too few arguments to function PlgContentJoomla::onContentBeforeSave(), 3 passed in D:\www\joomla4\libraries\src\Plugin\CMSPlugin.php on line 287 and exactly 4 expected